From 9f5b8bcad6c54bb29af5ab97fc14705e3e3dcbc6 Mon Sep 17 00:00:00 2001 From: Markus Date: Tue, 13 Feb 2024 10:34:28 +0100 Subject: [PATCH] feat: Add gitlab group visibility to group entity via annotation Signed-off-by: Markus --- .changeset/silent-insects-invent.md | 5 +++++ .../src/lib/defaultTransformers.ts | 1 + plugins/catalog-backend-module-gitlab/src/lib/types.ts | 1 + .../src/providers/GitlabOrgDiscoveryEntityProvider.test.ts | 1 + 4 files changed, 8 insertions(+) create mode 100644 .changeset/silent-insects-invent.md diff --git a/.changeset/silent-insects-invent.md b/.changeset/silent-insects-invent.md new file mode 100644 index 0000000000..8389f76a01 --- /dev/null +++ b/.changeset/silent-insects-invent.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog-backend-module-gitlab': patch +--- + +Add gitlab group visibility to group entity via annotation diff --git a/plugins/catalog-backend-module-gitlab/src/lib/defaultTransformers.ts b/plugins/catalog-backend-module-gitlab/src/lib/defaultTransformers.ts index d7a6bf76e9..ebdf91cf42 100644 --- a/plugins/catalog-backend-module-gitlab/src/lib/defaultTransformers.ts +++ b/plugins/catalog-backend-module-gitlab/src/lib/defaultTransformers.ts @@ -49,6 +49,7 @@ export function defaultGroupEntitiesTransformer( const annotations: { [annotationName: string]: string } = {}; annotations[`${options.providerConfig.host}/team-path`] = group.full_path; + annotations[`${options.providerConfig.host}/visibility`] = group.visibility; const entity: GroupEntity = { apiVersion: 'backstage.io/v1alpha1', diff --git a/plugins/catalog-backend-module-gitlab/src/lib/types.ts b/plugins/catalog-backend-module-gitlab/src/lib/types.ts index 25c9a4a232..635b7d4d6a 100644 --- a/plugins/catalog-backend-module-gitlab/src/lib/types.ts +++ b/plugins/catalog-backend-module-gitlab/src/lib/types.ts @@ -76,6 +76,7 @@ export type GitLabGroup = { name: string; full_path: string; description?: string; + visibility: string; parent_id?: number; }; diff --git a/plugins/catalog-backend-module-gitlab/src/providers/GitlabOrgDiscoveryEntityProvider.test.ts b/plugins/catalog-backend-module-gitlab/src/providers/GitlabOrgDiscoveryEntityProvider.test.ts index 669abc69b6..c86c9f52d4 100644 --- a/plugins/catalog-backend-module-gitlab/src/providers/GitlabOrgDiscoveryEntityProvider.test.ts +++ b/plugins/catalog-backend-module-gitlab/src/providers/GitlabOrgDiscoveryEntityProvider.test.ts @@ -452,6 +452,7 @@ describe('GitlabOrgDiscoveryEntityProvider', () => { 'backstage.io/managed-by-origin-location': 'url:https://test-gitlab/group1/group2', 'test-gitlab/team-path': 'group1/group2', + 'test-gitlab/visibility': 'internal', }, description: 'Group2', name: 'group1-group2',