From 9ecb8a595e7d535d2881d835c262dbbc9d3b3e4a Mon Sep 17 00:00:00 2001 From: Mustansar Anwar ul Samad Date: Wed, 11 Aug 2021 08:04:13 +1200 Subject: [PATCH] Rebase for prettier issues and add Bitbucket to vocab Signed-off-by: Mustansar Anwar ul Samad --- .changeset/perfect-seals-burn.md | 2 +- .github/styles/vocab.txt | 1 + .../src/components/fields/RepoUrlPicker/validation.ts | 2 -- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.changeset/perfect-seals-burn.md b/.changeset/perfect-seals-burn.md index 10503363de..8d3a1c7619 100644 --- a/.changeset/perfect-seals-burn.md +++ b/.changeset/perfect-seals-burn.md @@ -3,4 +3,4 @@ '@backstage/plugin-scaffolder-backend': minor --- -Add bitbucket workspace and project fields to RepoUrlPicker to support bitbucket cloud and server +Add Bitbucket workspace and project fields to RepoUrlPicker to support Bitbucket cloud and server diff --git a/.github/styles/vocab.txt b/.github/styles/vocab.txt index 6f28680ecb..fae8af80a0 100644 --- a/.github/styles/vocab.txt +++ b/.github/styles/vocab.txt @@ -15,6 +15,7 @@ Avro backrub Bigtable Billett +Bitbucket Bitrise Blackbox bool diff --git a/plugins/scaffolder/src/components/fields/RepoUrlPicker/validation.ts b/plugins/scaffolder/src/components/fields/RepoUrlPicker/validation.ts index 85232b0588..24a1c2f5ce 100644 --- a/plugins/scaffolder/src/components/fields/RepoUrlPicker/validation.ts +++ b/plugins/scaffolder/src/components/fields/RepoUrlPicker/validation.ts @@ -63,8 +63,6 @@ export const repoPickerValidation = ( ); } } - - // if (!host || !searchParams.get('owner') || !searchParams.get('repo')) { } catch { validation.addError('Unable to parse the Repository URL'); }