From 9e7893d50c5197507e6911889ab5e6ebd1cd39dc Mon Sep 17 00:00:00 2001
From: Bogdan Nechyporenko <bnechyporenko@bol.com>
Date: Wed, 25 Oct 2023 21:04:05 +0200
Subject: [PATCH] feedback

Signed-off-by: Bogdan Nechyporenko <bnechyporenko@bol.com>
---
 plugins/scaffolder-backend/config.d.ts           |  4 ++--
 plugins/scaffolder-backend/src/service/router.ts | 12 ++++++++----
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/plugins/scaffolder-backend/config.d.ts b/plugins/scaffolder-backend/config.d.ts
index 9d3fc1716d..3e98eda638 100644
--- a/plugins/scaffolder-backend/config.d.ts
+++ b/plugins/scaffolder-backend/config.d.ts
@@ -45,9 +45,9 @@ export interface Config {
      *
      * Staled tasks are marked as failed, once task's timeout has exceeded.
      *
-     * By default, processing interval is every 5 minutes.
+     * By default, the frequency is every 5 minutes.
      */
-    processingInterval: HumanDuration;
+    taskTimeoutReaperFrequency: HumanDuration;
 
     /**
      * Sets the task's heartbeat timeout, when to consider a task to be staled.
diff --git a/plugins/scaffolder-backend/src/service/router.ts b/plugins/scaffolder-backend/src/service/router.ts
index c51540f2ec..d434b0cf55 100644
--- a/plugins/scaffolder-backend/src/service/router.ts
+++ b/plugins/scaffolder-backend/src/service/router.ts
@@ -271,15 +271,19 @@ export async function createRouter(
     if (scheduler && databaseTaskStore.listStaleTasks) {
       await scheduler.scheduleTask({
         id: 'close_stale_tasks',
-        frequency: readDuration(config, 'scaffolder.processingInterval', {
-          minutes: 5,
-        }),
+        frequency: readDuration(
+          config,
+          'scaffolder.taskTimeoutReaperFrequency',
+          {
+            minutes: 5,
+          },
+        ),
         timeout: { minutes: 15 },
         fn: async () => {
           const { tasks } = await databaseTaskStore.listStaleTasks({
             timeoutS: Duration.fromObject(
               readDuration(config, 'scaffolder.taskTimeout', {
-                seconds: 86400,
+                hours: 24,
               }),
             ).as('seconds'),
           });