From 9d89aed378b3929ef6c01469825b33471498aff6 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Tue, 2 Apr 2024 10:59:39 +0200 Subject: [PATCH] kubernetes-backend: fix reading credentials from undefined Signed-off-by: Patrik Oldsberg --- .changeset/little-bats-admire.md | 5 +++++ .../src/cluster-locator/CatalogClusterLocator.ts | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/little-bats-admire.md diff --git a/.changeset/little-bats-admire.md b/.changeset/little-bats-admire.md new file mode 100644 index 0000000000..9b7c137cf8 --- /dev/null +++ b/.changeset/little-bats-admire.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-kubernetes-backend': patch +--- + +Fixed a crash reading `credentials` from `undefined`. diff --git a/plugins/kubernetes-backend/src/cluster-locator/CatalogClusterLocator.ts b/plugins/kubernetes-backend/src/cluster-locator/CatalogClusterLocator.ts index 76268457c5..f8e921828e 100644 --- a/plugins/kubernetes-backend/src/cluster-locator/CatalogClusterLocator.ts +++ b/plugins/kubernetes-backend/src/cluster-locator/CatalogClusterLocator.ts @@ -52,7 +52,7 @@ export class CatalogClusterLocator implements KubernetesClustersSupplier { return new CatalogClusterLocator(catalogApi, auth); } - async getClusters(options: { + async getClusters(options?: { credentials: BackstageCredentials; }): Promise { const apiServerKey = `metadata.annotations.${ANNOTATION_KUBERNETES_API_SERVER}`; @@ -71,7 +71,7 @@ export class CatalogClusterLocator implements KubernetesClustersSupplier { { filter: [filter], }, - options.credentials + options?.credentials ? { token: ( await this.auth.getPluginRequestToken({