From 829f14a9b09538ba6de31bf29214c0eadf29a816 Mon Sep 17 00:00:00 2001 From: Camila Belo Date: Fri, 12 Aug 2022 15:27:25 +0200 Subject: [PATCH] fix(techdocs): to update title and subtitle when location changes Signed-off-by: Camila Belo --- .changeset/techdocs-jeans-wait.md | 5 +++++ .../TechDocsReaderPageHeader.tsx | 9 +++------ 2 files changed, 8 insertions(+), 6 deletions(-) create mode 100644 .changeset/techdocs-jeans-wait.md diff --git a/.changeset/techdocs-jeans-wait.md b/.changeset/techdocs-jeans-wait.md new file mode 100644 index 0000000000..b4d9007754 --- /dev/null +++ b/.changeset/techdocs-jeans-wait.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-techdocs': patch +--- + +Always update the title and sub-title when the location changes on a `TechDocs` reader page. diff --git a/plugins/techdocs/src/reader/components/TechDocsReaderPageHeader/TechDocsReaderPageHeader.tsx b/plugins/techdocs/src/reader/components/TechDocsReaderPageHeader/TechDocsReaderPageHeader.tsx index 8826154eee..e76cb1d173 100644 --- a/plugins/techdocs/src/reader/components/TechDocsReaderPageHeader/TechDocsReaderPageHeader.tsx +++ b/plugins/techdocs/src/reader/components/TechDocsReaderPageHeader/TechDocsReaderPageHeader.tsx @@ -77,16 +77,13 @@ export const TechDocsReaderPageHeader = ( useEffect(() => { if (!metadata) return; - setTitle(prevTitle => { - const { site_name } = metadata; - return prevTitle || site_name; - }); - setSubtitle(prevSubtitle => { + setTitle(metadata.site_name); + setSubtitle(() => { let { site_description } = metadata; if (!site_description || site_description === 'None') { site_description = 'Home'; } - return prevSubtitle || site_description; + return site_description; }); }, [metadata, setTitle, setSubtitle]);