From fc1705050ef8d2312f49c675b7c20aea31f95629 Mon Sep 17 00:00:00 2001 From: Abhishek Jakhar Date: Sat, 17 Oct 2020 08:15:31 +0530 Subject: [PATCH 1/2] give aria-label attribute to Status Ok, Warning and Error --- .../core/src/components/Status/Status.tsx | 20 ++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/packages/core/src/components/Status/Status.tsx b/packages/core/src/components/Status/Status.tsx index 9a5ce5b218..6a2e753f1f 100644 --- a/packages/core/src/components/Status/Status.tsx +++ b/packages/core/src/components/Status/Status.tsx @@ -65,20 +65,34 @@ const useStyles = makeStyles(theme => ({ export const StatusOK: FC<{}> = props => { const classes = useStyles(props); - return ; + return ( + + ); }; export const StatusWarning: FC<{}> = props => { const classes = useStyles(props); return ( - + ); }; export const StatusError: FC<{}> = props => { const classes = useStyles(props); return ( - + ); }; From 754e31db5e0438038105d3d0636afe2fc3e89cbd Mon Sep 17 00:00:00 2001 From: Abhishek Jakhar Date: Sat, 17 Oct 2020 08:20:35 +0530 Subject: [PATCH 2/2] add changeset --- .changeset/swift-peas-argue.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/swift-peas-argue.md diff --git a/.changeset/swift-peas-argue.md b/.changeset/swift-peas-argue.md new file mode 100644 index 0000000000..d78d844d45 --- /dev/null +++ b/.changeset/swift-peas-argue.md @@ -0,0 +1,5 @@ +--- +'@backstage/core': patch +--- + +give aria-label attribute to Status Ok, Warning and Error