From 9ccbf2658190b18e06dbf6ec146995fe08dd26b9 Mon Sep 17 00:00:00 2001
From: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
Date: Wed, 7 Dec 2022 13:35:21 -0500
Subject: [PATCH] fix: Move rules to root of project

Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
---
 .eslintrc.js                          |  8 +++++++-
 package.json                          |  2 ++
 packages/cli/config/eslint-factory.js |  8 --------
 yarn.lock                             | 14 +++++++++++++-
 4 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index 675a834efb..4e6bbd3910 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -18,7 +18,7 @@ var path = require('path');
 
 module.exports = {
   root: true,
-  plugins: ['notice', 'testing-library'],
+  plugins: ['@spotify', 'notice', 'react', 'testing-library'],
   rules: {
     'notice/notice': [
       'error',
@@ -45,6 +45,12 @@ module.exports = {
           "CallExpression[arguments.length=0] > MemberExpression[property.name='toUpperCase']",
       },
     ],
+    'react/forbid-elements': [
+      1,
+      {
+        forbid: [{ element: 'button', message: 'use MUI <Button> instead' }],
+      },
+    ],
     'testing-library/await-async-query': 'error',
     'testing-library/await-async-utils': 'error',
     'testing-library/no-await-sync-query': 'error',
diff --git a/package.json b/package.json
index 0bee2ed48f..acdb961d0c 100644
--- a/package.json
+++ b/package.json
@@ -58,6 +58,7 @@
     "@backstage/repo-tools": "workspace:*",
     "@changesets/cli": "^2.14.0",
     "@octokit/rest": "^19.0.3",
+    "@spotify/eslint-plugin": "^14.1.3",
     "@spotify/prettier-config": "^14.0.0",
     "@techdocs/cli": "workspace:*",
     "@types/node": "^16.11.26",
@@ -68,6 +69,7 @@
     "e2e-test": "workspace:*",
     "eslint": "^8.6.0",
     "eslint-plugin-notice": "^0.9.10",
+    "eslint-plugin-react": "^7.31.11",
     "eslint-plugin-testing-library": "^5.9.1",
     "fs-extra": "10.1.0",
     "husky": "^8.0.0",
diff --git a/packages/cli/config/eslint-factory.js b/packages/cli/config/eslint-factory.js
index f4a543fe75..c46dac20d1 100644
--- a/packages/cli/config/eslint-factory.js
+++ b/packages/cli/config/eslint-factory.js
@@ -219,14 +219,6 @@ function createConfigForRole(dir, role, extraConfig = {}) {
         ],
         rules: {
           ...extraConfig.rules,
-          'react/forbid-elements': [
-            1,
-            {
-              forbid: [
-                { element: 'button', message: 'use MUI <Button> instead' },
-              ],
-            },
-          ],
         },
         parserOptions: {
           ecmaFeatures: {
diff --git a/yarn.lock b/yarn.lock
index 4d60c18102..bb78316755 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -13166,6 +13166,16 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@spotify/eslint-plugin@npm:^14.1.3":
+  version: 14.1.3
+  resolution: "@spotify/eslint-plugin@npm:14.1.3"
+  peerDependencies:
+    "@typescript-eslint/parser": ^5.13.0
+    eslint: ^8.10.0
+  checksum: 788f5d9aab6f7b6c0ad7e414ebd5f4504f058f26a769dc4bcd0088dd8e6d9e5334965c8f6fffcf5b7ed52dbe25de0dc7bba403bcffa79b6d94c7ba3094757b5f
+  languageName: node
+  linkType: hard
+
 "@spotify/prettier-config@npm:^14.0.0":
   version: 14.0.1
   resolution: "@spotify/prettier-config@npm:14.0.1"
@@ -21851,7 +21861,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"eslint-plugin-react@npm:^7.28.0":
+"eslint-plugin-react@npm:^7.28.0, eslint-plugin-react@npm:^7.31.11":
   version: 7.31.11
   resolution: "eslint-plugin-react@npm:7.31.11"
   dependencies:
@@ -34421,6 +34431,7 @@ __metadata:
     "@changesets/cli": ^2.14.0
     "@manypkg/get-packages": ^1.1.3
     "@octokit/rest": ^19.0.3
+    "@spotify/eslint-plugin": ^14.1.3
     "@spotify/prettier-config": ^14.0.0
     "@techdocs/cli": "workspace:*"
     "@types/node": ^16.11.26
@@ -34431,6 +34442,7 @@ __metadata:
     e2e-test: "workspace:*"
     eslint: ^8.6.0
     eslint-plugin-notice: ^0.9.10
+    eslint-plugin-react: ^7.31.11
     eslint-plugin-testing-library: ^5.9.1
     fs-extra: 10.1.0
     husky: ^8.0.0