From 9b0db3f495e04a8381c91bd1e7d5f3168d1067cc Mon Sep 17 00:00:00 2001 From: Ryan Hanchett Date: Tue, 7 May 2024 14:08:45 -0700 Subject: [PATCH] chore: clean up comments before opening PR Signed-off-by: Ryan Hanchett --- .../src/services/implementations/auth/external/jwks.test.ts | 2 -- .../src/services/implementations/auth/external/jwks.ts | 1 - 2 files changed, 3 deletions(-) diff --git a/packages/backend-app-api/src/services/implementations/auth/external/jwks.test.ts b/packages/backend-app-api/src/services/implementations/auth/external/jwks.test.ts index c4d9f37b23..95df6f56ff 100644 --- a/packages/backend-app-api/src/services/implementations/auth/external/jwks.test.ts +++ b/packages/backend-app-api/src/services/implementations/auth/external/jwks.test.ts @@ -28,8 +28,6 @@ interface AnyJWK extends Record { kty: string; } // Simplified copy of TokenFactory in @backstage/plugin-auth-backend -// Since this is re-used in several tests, I wonder if it should get refactored -// into @backstage/backend-test-utils class FakeTokenFactory { private readonly keys = new Array(); diff --git a/packages/backend-app-api/src/services/implementations/auth/external/jwks.ts b/packages/backend-app-api/src/services/implementations/auth/external/jwks.ts index 34683647df..5c3738504d 100644 --- a/packages/backend-app-api/src/services/implementations/auth/external/jwks.ts +++ b/packages/backend-app-api/src/services/implementations/auth/external/jwks.ts @@ -34,7 +34,6 @@ export class JWKSHandler implements TokenHandler { add(options: Config) { const algorithms = options.getOptionalStringArray('algorithms') ?? []; const issuers = options.getOptionalStringArray('issuers') ?? []; - // if audience is unset, an empty string is valid, but an empty array is not const audiences = options.getOptionalStringArray('audiences') ?? ''; const uri = options.getString('uri');