From cdd58f35473d0d9aac3671f2dedc62d77b5e0ce9 Mon Sep 17 00:00:00 2001 From: Marco Crivellaro Date: Mon, 28 Mar 2022 15:37:11 +0000 Subject: [PATCH 1/3] awsalb auth doesn't support authEnv Signed-off-by: Marco Crivellaro --- contrib/docs/tutorials/aws-alb-aad-oidc-auth.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/contrib/docs/tutorials/aws-alb-aad-oidc-auth.md b/contrib/docs/tutorials/aws-alb-aad-oidc-auth.md index a95b276365..72b615ea33 100644 --- a/contrib/docs/tutorials/aws-alb-aad-oidc-auth.md +++ b/contrib/docs/tutorials/aws-alb-aad-oidc-auth.md @@ -182,9 +182,8 @@ Use the following `auth` configuration when running Backstage on AWS: auth: providers: awsalb: - development: - issuer: https://login.microsoftonline.com//v2.0 - region: + issuer: https://login.microsoftonline.com//v2.0 + region: ``` Replace `` with the value of `Directory (tenant) ID` of the AAD App and `` with the AWS region identifier where the ALB is deployed (for example: `eu-central-1`). From 9e33ed23b8691079a01ffee7b2c1352473b0bce5 Mon Sep 17 00:00:00 2001 From: Marco Crivellaro Date: Mon, 28 Mar 2022 15:38:25 +0000 Subject: [PATCH 2/3] the aws alb provider name is awsalb (not aws-alb) Signed-off-by: Marco Crivellaro --- .../src/layout/ProxiedSignInPage/ProxiedSignInPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core-components/src/layout/ProxiedSignInPage/ProxiedSignInPage.tsx b/packages/core-components/src/layout/ProxiedSignInPage/ProxiedSignInPage.tsx index 13a61d259f..965c603004 100644 --- a/packages/core-components/src/layout/ProxiedSignInPage/ProxiedSignInPage.tsx +++ b/packages/core-components/src/layout/ProxiedSignInPage/ProxiedSignInPage.tsx @@ -32,7 +32,7 @@ import { ProxiedSignInIdentity } from './ProxiedSignInIdentity'; */ export type ProxiedSignInPageProps = SignInPageProps & { /** - * The provider to use, e.g. "gcp-iap" or "aws-alb". This must correspond to + * The provider to use, e.g. "gcp-iap" or "awsalb". This must correspond to * a properly configured auth provider ID in the auth backend. */ provider: string; From 72f3dfd05a147fd157c85309578b44edb7e41eff Mon Sep 17 00:00:00 2001 From: Marco Crivellaro Date: Wed, 30 Mar 2022 21:34:45 +0100 Subject: [PATCH 3/3] adding changeset Signed-off-by: Marco Crivellaro --- .changeset/tasty-pears-shake.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tasty-pears-shake.md diff --git a/.changeset/tasty-pears-shake.md b/.changeset/tasty-pears-shake.md new file mode 100644 index 0000000000..565cb02b77 --- /dev/null +++ b/.changeset/tasty-pears-shake.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +Updated ProxiedSignInPageProps docs