dev-tools - Fixed deprecated code
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
This commit is contained in:
@@ -0,0 +1,5 @@
|
||||
---
|
||||
'@backstage/plugin-devtools-backend': patch
|
||||
---
|
||||
|
||||
Removed the usage of `permissionIntegrationRouter` in favor of using the new `coreServices.permissionsRegistry`
|
||||
@@ -19,6 +19,7 @@ import {
|
||||
createBackendPlugin,
|
||||
} from '@backstage/backend-plugin-api';
|
||||
import { createRouter } from './service/router';
|
||||
import { devToolsPermissions } from '@backstage/plugin-devtools-common';
|
||||
|
||||
/**
|
||||
* DevTools backend plugin
|
||||
@@ -36,6 +37,7 @@ export const devtoolsPlugin = createBackendPlugin({
|
||||
httpRouter: coreServices.httpRouter,
|
||||
discovery: coreServices.discovery,
|
||||
httpAuth: coreServices.httpAuth,
|
||||
permissionsRegistry: coreServices.permissionsRegistry,
|
||||
},
|
||||
async init({
|
||||
config,
|
||||
@@ -44,6 +46,7 @@ export const devtoolsPlugin = createBackendPlugin({
|
||||
httpRouter,
|
||||
discovery,
|
||||
httpAuth,
|
||||
permissionsRegistry,
|
||||
}) {
|
||||
httpRouter.use(
|
||||
await createRouter({
|
||||
@@ -58,6 +61,7 @@ export const devtoolsPlugin = createBackendPlugin({
|
||||
path: '/health',
|
||||
allow: 'unauthenticated',
|
||||
});
|
||||
permissionsRegistry.addPermissions(devToolsPermissions);
|
||||
},
|
||||
});
|
||||
},
|
||||
|
||||
@@ -19,13 +19,11 @@ import {
|
||||
devToolsConfigReadPermission,
|
||||
devToolsExternalDependenciesReadPermission,
|
||||
devToolsInfoReadPermission,
|
||||
devToolsPermissions,
|
||||
} from '@backstage/plugin-devtools-common';
|
||||
import { DevToolsBackendApi } from '../api';
|
||||
import { NotAllowedError } from '@backstage/errors';
|
||||
import Router from 'express-promise-router';
|
||||
import express from 'express';
|
||||
import { createPermissionIntegrationRouter } from '@backstage/plugin-permission-node';
|
||||
import {
|
||||
DiscoveryService,
|
||||
HttpAuthService,
|
||||
@@ -59,11 +57,6 @@ export async function createRouter(
|
||||
|
||||
const router = Router();
|
||||
router.use(express.json());
|
||||
router.use(
|
||||
createPermissionIntegrationRouter({
|
||||
permissions: devToolsPermissions,
|
||||
}),
|
||||
);
|
||||
|
||||
router.get('/health', (_req, res) => {
|
||||
res.status(200).json({ status: 'ok' });
|
||||
|
||||
Reference in New Issue
Block a user