From 9a85135e1241a49c566b3383fd513165648b42f4 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Wed, 10 Mar 2021 16:24:21 +0100 Subject: [PATCH] storybook: switch to reading stories from components package Co-authored-by: Juan Lulkin Signed-off-by: Patrik Oldsberg --- packages/storybook/.storybook/main.js | 6 +++--- packages/storybook/README.md | 4 ++-- packages/storybook/package.json | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/storybook/.storybook/main.js b/packages/storybook/.storybook/main.js index 77bafdd231..cd2d3f24b0 100644 --- a/packages/storybook/.storybook/main.js +++ b/packages/storybook/.storybook/main.js @@ -3,8 +3,8 @@ const WebpackPluginFailBuildOnWarning = require('./webpack-plugin-fail-build-on- module.exports = { stories: [ - '../../core/src/layout/**/*.stories.tsx', - '../../core/src/components/**/*.stories.tsx', + '../../components/src/layout/**/*.stories.tsx', + '../../components/src/components/**/*.stories.tsx', '../../../plugins/**/src/**/*.stories.tsx', ], addons: [ @@ -15,7 +15,7 @@ module.exports = { ], webpackFinal: async config => { /* eslint-disable-next-line no-restricted-syntax */ - const coreSrc = path.resolve(__dirname, '../../core/src'); + const componentsSrc = path.resolve(__dirname, '../../components/src'); // Mirror config in packages/cli/src/lib/bundler config.resolve.mainFields = ['browser', 'module', 'main']; diff --git a/packages/storybook/README.md b/packages/storybook/README.md index 3e88b54db0..656fc578c2 100644 --- a/packages/storybook/README.md +++ b/packages/storybook/README.md @@ -2,6 +2,6 @@ This package provides a Storybook build for Backstage. See https://backstage.io/storybook/. -## Why is this not part of `@backstage/core`? +## Why is this not part of `@backstage/components`? -This separate storybook package exists because of dependency conflicts with `@backstage/cli`. It uses `nohoist` to avoid the conflicts, and since you can only use that in private packages it has to be separated out of `@backstage/core`. +This separate storybook package exists because of dependency conflicts with `@backstage/cli`. It uses `nohoist` to avoid the conflicts, and since you can only use that in private packages it has to be separated out of `@backstage/components`. diff --git a/packages/storybook/package.json b/packages/storybook/package.json index 4a4c1431c5..025e5d2f1f 100644 --- a/packages/storybook/package.json +++ b/packages/storybook/package.json @@ -1,7 +1,7 @@ { "name": "storybook", "version": "0.2.0", - "description": "Storybook build for core package", + "description": "Storybook build for components package", "private": true, "scripts": { "start": "start-storybook -p 6006",