diff --git a/plugins/tech-radar/src/api.ts b/plugins/tech-radar/src/api.ts index 5f3c0098f2..8f88b1a8b6 100644 --- a/plugins/tech-radar/src/api.ts +++ b/plugins/tech-radar/src/api.ts @@ -116,7 +116,7 @@ export interface RadarEntry { * * Empty is the default and the value possible are the same as W3C definition */ - urlTarget: string; + urlTarget?: string; /** * History of the Entry moving through {@link RadarRing} */ diff --git a/plugins/tech-radar/src/sample.ts b/plugins/tech-radar/src/sample.ts index c2c390af32..ba3fc632ab 100644 --- a/plugins/tech-radar/src/sample.ts +++ b/plugins/tech-radar/src/sample.ts @@ -51,7 +51,7 @@ entries.push({ title: 'JavaScript', quadrant: 'languages', description: - 'Excepteur **sint** occaecat *cupidatat* non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.\n\n```ts\nconst x = "3";\n```\n', + 'Excepteur **sint** occaecat *cupidatat* non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.\n\n```ts\nconst x = "3";\n```\n' }); entries.push({ timeline: [ diff --git a/plugins/tech-radar/src/utils/components.tsx b/plugins/tech-radar/src/utils/components.tsx index bbfe046b69..24623738f4 100644 --- a/plugins/tech-radar/src/utils/components.tsx +++ b/plugins/tech-radar/src/utils/components.tsx @@ -14,22 +14,25 @@ * limitations under the License. */ import React from 'react'; +import { Link } from '@backstage/core-components'; type WithLinkProps = { url?: string; + urlTarget?: string; className: string; children: React.ReactNode; }; export const WithLink = ({ url, + urlTarget, className, children, }: WithLinkProps): JSX.Element => url ? ( - + {children} - + ) : ( <>{children} ); diff --git a/plugins/tech-radar/src/utils/types.ts b/plugins/tech-radar/src/utils/types.ts index a0ed2d3576..884c99f93b 100644 --- a/plugins/tech-radar/src/utils/types.ts +++ b/plugins/tech-radar/src/utils/types.ts @@ -62,7 +62,7 @@ export type Entry = { // An URL to a longer description as to why this entry is where it is url?: string; // The URL target definition as W3C definition - urlTarget?: String; + urlTarget?: string; // How this entry has recently moved; -1 for "down", +1 for "up", 0 for not moved moved?: MovedState; // Most recent description to display in the UI