From 9a0672a9c7d20b590e3a9ad168ff7bf27b45d549 Mon Sep 17 00:00:00 2001 From: Stephen Glass Date: Tue, 20 Aug 2024 18:38:23 -0400 Subject: [PATCH] secrets on review page show constant asterisks value Signed-off-by: Stephen Glass --- .changeset/unlucky-cycles-clean.md | 5 +++++ .../src/next/components/ReviewState/ReviewState.tsx | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 .changeset/unlucky-cycles-clean.md diff --git a/.changeset/unlucky-cycles-clean.md b/.changeset/unlucky-cycles-clean.md new file mode 100644 index 0000000000..5b582dec59 --- /dev/null +++ b/.changeset/unlucky-cycles-clean.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder-react': patch +--- + +Scaffolder review page shows static amount of asterisks for secret fields. diff --git a/plugins/scaffolder-react/src/next/components/ReviewState/ReviewState.tsx b/plugins/scaffolder-react/src/next/components/ReviewState/ReviewState.tsx index d87584afff..725db8bee1 100644 --- a/plugins/scaffolder-react/src/next/components/ReviewState/ReviewState.tsx +++ b/plugins/scaffolder-react/src/next/components/ReviewState/ReviewState.tsx @@ -52,7 +52,10 @@ function processSchema( } } - if (definitionInSchema['ui:widget'] === 'password') { + if ( + definitionInSchema['ui:widget'] === 'password' || + definitionInSchema['ui:field']?.toLocaleLowerCase('en-us') === 'secret' + ) { return [[getLastKey(key), '******']]; }