diff --git a/.changeset/lemon-months-press.md b/.changeset/lemon-months-press.md new file mode 100644 index 0000000000..ecefc64daa --- /dev/null +++ b/.changeset/lemon-months-press.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +No `undefined` class name used at `MarkdownContent` if no custom class name was provided. diff --git a/packages/core-components/src/components/MarkdownContent/MarkdownContent.test.tsx b/packages/core-components/src/components/MarkdownContent/MarkdownContent.test.tsx index 4f28da0118..d9d82437e4 100644 --- a/packages/core-components/src/components/MarkdownContent/MarkdownContent.test.tsx +++ b/packages/core-components/src/components/MarkdownContent/MarkdownContent.test.tsx @@ -45,6 +45,36 @@ describe('', () => { ).toBeInTheDocument(); }); + it('Render MarkdownContent component without custom class', async () => { + await renderInTestApp( + , + ); + const content = screen.getByText('https://example.com', { selector: 'p' }); + + expect( + Array.from(content.parentElement?.classList?.values() ?? []).map(cls => + cls.replace(/-\d+$/, ''), + ), + ).toEqual(['BackstageMarkdownContent-markdown']); + }); + + it('Render MarkdownContent component with custom class', async () => { + await renderInTestApp( + , + ); + const content = screen.getByText('https://example.com', { selector: 'p' }); + + expect( + Array.from(content.parentElement?.classList?.values() ?? []).map(cls => + cls.replace(/-\d+$/, ''), + ), + ).toEqual(['BackstageMarkdownContent-markdown', 'custom-class']); + }); + it('render MarkdownContent component with CodeSnippet for code blocks', async () => { await renderInTestApp( , diff --git a/packages/core-components/src/components/MarkdownContent/MarkdownContent.tsx b/packages/core-components/src/components/MarkdownContent/MarkdownContent.tsx index b422a62b6c..f536b20106 100644 --- a/packages/core-components/src/components/MarkdownContent/MarkdownContent.tsx +++ b/packages/core-components/src/components/MarkdownContent/MarkdownContent.tsx @@ -127,7 +127,7 @@ export function MarkdownContent(props: Props) { return (