refactor: address PR comments

This commit is contained in:
Ivan Shmidt
2020-09-02 15:56:14 +02:00
parent 9a99a92f84
commit 9988479c61
16 changed files with 86 additions and 78 deletions
+2 -2
View File
@@ -27,9 +27,9 @@ This helps the community know what plugins are in development.
You can also use this process if you have an idea for a good plugin but you hope
that someone else will pick up the work.
## Integrate into the catalog service
## Integrate into the Service Catalog
If your plugin isn't supposed to live as a standalone page, but rather needs to
be presented as a part of a catalog service (e.g. a separate tab or a card on an
be presented as a part of a Service Catalog (e.g. a separate tab or a card on an
"Overview" tab), then check out
[the instruction](integrating-plugin-into-service-catalog.md). on how to do it.
@@ -1,6 +1,6 @@
---
id: integrating-plugin-into-service-catalog
title: Integrate into the catalog service
title: Integrate into the Service Catalog
---
> This is an advanced use case and currently is an experimental feature. Expect
@@ -119,7 +119,6 @@ type EntityPageLayoutContentProps = {
};
```
> The recommended pattern is to get the `entity` in the App and then pass it to
> the plugin's Router component as a prop. However if it inconvenient for you,
> You can either pass the entity from App to the plugin's router as a prop or
> use `useEntity` hook from `@backstage/plugin-catalog` directly inside your
> plugin.