From 997301c0664a5606477f4f6210dd7cdc1031262d Mon Sep 17 00:00:00 2001
From: Paul Cowan <paul.cowan@cutting.scot>
Date: Mon, 12 Dec 2022 08:07:07 +0000
Subject: [PATCH] make onComplete not required

Signed-off-by: Paul Cowan <paul.cowan@cutting.scot>
---
 .../EmbeddedScaffolderWorkflow.tsx                         | 7 +++++--
 packages/app/src/components/SecurityTab/SecurityTab.tsx    | 5 ++++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/packages/app/src/components/EmbeddedScaffolderWorkflow/EmbeddedScaffolderWorkflow.tsx b/packages/app/src/components/EmbeddedScaffolderWorkflow/EmbeddedScaffolderWorkflow.tsx
index d5c86ff04d..3587edd12e 100644
--- a/packages/app/src/components/EmbeddedScaffolderWorkflow/EmbeddedScaffolderWorkflow.tsx
+++ b/packages/app/src/components/EmbeddedScaffolderWorkflow/EmbeddedScaffolderWorkflow.tsx
@@ -25,7 +25,10 @@ import { Box, Button } from '@material-ui/core';
 import type { JsonValue } from '@backstage/types';
 import type { FormProps } from '@backstage/plugin-scaffolder-react';
 
-type EmbeddedWorkflowProps = Omit<WorkflowProps, 'customFieldExtensions'> & {
+type EmbeddedWorkflowProps = Omit<
+  WorkflowProps,
+  'customFieldExtensions' | 'onComplete'
+> & {
   customExtensionsElement?: React.ReactNode;
   initialFormState?: Record<string, JsonValue>;
   onComplete: (values: Record<string, JsonValue>) => Promise<void>;
@@ -33,7 +36,7 @@ type EmbeddedWorkflowProps = Omit<WorkflowProps, 'customFieldExtensions'> & {
   FormProps: FormProps
   frontPage: ReactNode;
   finishPage: ReactNode;
-};
+} & Partial<Pick<WorkflowProps, 'onComplete'>>;
 
 type Display = 'front' | 'workflow' | 'finish';
 
diff --git a/packages/app/src/components/SecurityTab/SecurityTab.tsx b/packages/app/src/components/SecurityTab/SecurityTab.tsx
index 1841a4357e..b9c1eccd02 100644
--- a/packages/app/src/components/SecurityTab/SecurityTab.tsx
+++ b/packages/app/src/components/SecurityTab/SecurityTab.tsx
@@ -26,9 +26,12 @@ const ReviewWrapper = () => {
   );
 };
 
+/*
+ * This is an exmaple component that uses the <EmbeddedScaffolderWorkflow />
+ */
 export function SecurityTab(): JSX.Element | null {
   // eslint-disable-next-line no-console
-  const onComplete = async () => console.log('onComplete called from ');
+  const onComplete = async () => console.log('we can add to onComplete here');
 
   const onError = (error: Error | undefined) => (
     <h2>{error?.message ?? 'Houston we have a problem.'}</h2>