diff --git a/packages/app/src/components/EmbeddedScaffolderWorkflow/EmbeddedScaffolderWorkflow.tsx b/packages/app/src/components/EmbeddedScaffolderWorkflow/EmbeddedScaffolderWorkflow.tsx index d5c86ff04d..3587edd12e 100644 --- a/packages/app/src/components/EmbeddedScaffolderWorkflow/EmbeddedScaffolderWorkflow.tsx +++ b/packages/app/src/components/EmbeddedScaffolderWorkflow/EmbeddedScaffolderWorkflow.tsx @@ -25,7 +25,10 @@ import { Box, Button } from '@material-ui/core'; import type { JsonValue } from '@backstage/types'; import type { FormProps } from '@backstage/plugin-scaffolder-react'; -type EmbeddedWorkflowProps = Omit & { +type EmbeddedWorkflowProps = Omit< + WorkflowProps, + 'customFieldExtensions' | 'onComplete' +> & { customExtensionsElement?: React.ReactNode; initialFormState?: Record; onComplete: (values: Record) => Promise; @@ -33,7 +36,7 @@ type EmbeddedWorkflowProps = Omit & { FormProps: FormProps frontPage: ReactNode; finishPage: ReactNode; -}; +} & Partial>; type Display = 'front' | 'workflow' | 'finish'; diff --git a/packages/app/src/components/SecurityTab/SecurityTab.tsx b/packages/app/src/components/SecurityTab/SecurityTab.tsx index 1841a4357e..b9c1eccd02 100644 --- a/packages/app/src/components/SecurityTab/SecurityTab.tsx +++ b/packages/app/src/components/SecurityTab/SecurityTab.tsx @@ -26,9 +26,12 @@ const ReviewWrapper = () => { ); }; +/* + * This is an exmaple component that uses the + */ export function SecurityTab(): JSX.Element | null { // eslint-disable-next-line no-console - const onComplete = async () => console.log('onComplete called from '); + const onComplete = async () => console.log('we can add to onComplete here'); const onError = (error: Error | undefined) => (

{error?.message ?? 'Houston we have a problem.'}