From 2837dec850f8d22b16d559127b7f1ef547e5cafd Mon Sep 17 00:00:00 2001 From: Erik Larsson Date: Sun, 20 Dec 2020 19:30:01 +0100 Subject: [PATCH 1/5] fix(app): listen to app.listen.host --- packages/cli/src/lib/bundler/server.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/src/lib/bundler/server.ts b/packages/cli/src/lib/bundler/server.ts index a5cdd1300c..34284ead18 100644 --- a/packages/cli/src/lib/bundler/server.ts +++ b/packages/cli/src/lib/bundler/server.ts @@ -61,7 +61,7 @@ export async function serveBundle(options: ServeOptions) { }); await new Promise((resolve, reject) => { - server.listen(port, url.hostname, (err?: Error) => { + server.listen(port, host, (err?: Error) => { if (err) { reject(err); return; From f3dc154965112c5c8662815fc63a6312d1511bd8 Mon Sep 17 00:00:00 2001 From: Erik Larsson Date: Mon, 21 Dec 2020 10:14:44 +0100 Subject: [PATCH 2/5] Added changeset --- .changeset/fuzzy-windows-cry.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fuzzy-windows-cry.md diff --git a/.changeset/fuzzy-windows-cry.md b/.changeset/fuzzy-windows-cry.md new file mode 100644 index 0000000000..1eb262c551 --- /dev/null +++ b/.changeset/fuzzy-windows-cry.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +Use app.listen.host configuration when starting dev server From 7d72f9b09855b6decb4b042a0f9d921974a35495 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 21 Dec 2020 10:21:08 +0100 Subject: [PATCH 3/5] Create violet-sloths-reply.md --- .changeset/violet-sloths-reply.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/violet-sloths-reply.md diff --git a/.changeset/violet-sloths-reply.md b/.changeset/violet-sloths-reply.md new file mode 100644 index 0000000000..c6f065aaf6 --- /dev/null +++ b/.changeset/violet-sloths-reply.md @@ -0,0 +1,5 @@ +--- +"@backstage/cli": patch +--- + +Fix for `app.listen.host` configuration not properly overriding listening host. From 5c71d6cdfa8b79b5f84bfac68ea1061f8f909cf2 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 21 Dec 2020 10:24:07 +0100 Subject: [PATCH 4/5] Delete fuzzy-windows-cry.md --- .changeset/fuzzy-windows-cry.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .changeset/fuzzy-windows-cry.md diff --git a/.changeset/fuzzy-windows-cry.md b/.changeset/fuzzy-windows-cry.md deleted file mode 100644 index 1eb262c551..0000000000 --- a/.changeset/fuzzy-windows-cry.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@backstage/cli': patch ---- - -Use app.listen.host configuration when starting dev server From f60efae2889f7b3f4a8135359e56776bbb69f8fb Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 21 Dec 2020 10:31:35 +0100 Subject: [PATCH 5/5] Update violet-sloths-reply.md --- .changeset/violet-sloths-reply.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/violet-sloths-reply.md b/.changeset/violet-sloths-reply.md index c6f065aaf6..ea73a8b22e 100644 --- a/.changeset/violet-sloths-reply.md +++ b/.changeset/violet-sloths-reply.md @@ -1,5 +1,5 @@ --- -"@backstage/cli": patch +'@backstage/cli': patch --- Fix for `app.listen.host` configuration not properly overriding listening host.