From 99471cd9637ac57a248cf4601128baa0901eb1d2 Mon Sep 17 00:00:00 2001 From: Hitoshi Kamezaki Date: Tue, 22 Oct 2024 14:09:39 +0900 Subject: [PATCH] RepoUrlPickerRepoName did not keep the input value Use onInputChange instead of onChange for propagating the input evnet. Previous version was used . In this case onChange was fired each input event. But in is not fired. Signed-off-by: Hitoshi Kamezaki --- .changeset/rare-trains-scream.md | 5 +++++ .../fields/RepoUrlPicker/RepoUrlPickerRepoName.tsx | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/rare-trains-scream.md diff --git a/.changeset/rare-trains-scream.md b/.changeset/rare-trains-scream.md new file mode 100644 index 0000000000..5e1a6e69f4 --- /dev/null +++ b/.changeset/rare-trains-scream.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder': patch +--- + +fix(scaffolder): use onInputChange instead onChange in RepoUrlPickerRepoName because need to keep the input value when move focus. diff --git a/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPickerRepoName.tsx b/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPickerRepoName.tsx index 9c63140d1c..b1152d3c1f 100644 --- a/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPickerRepoName.tsx +++ b/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPickerRepoName.tsx @@ -67,7 +67,7 @@ export const RepoUrlPickerRepoName = (props: { ) : ( { + onInputChange={(_, newValue) => { onChange(newValue || ''); }} options={availableRepos || []}