From 98b2bd1b51688ae5947a755dc13e023a6fa5e739 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Wed, 18 Jan 2023 21:53:55 +0100 Subject: [PATCH] eslint-plugin: added missing deps + lint config Signed-off-by: Patrik Oldsberg --- packages/eslint-plugin/.eslintrc.js | 35 +++++++++++++++++++++++++++++ packages/eslint-plugin/package.json | 11 ++++++++- yarn.lock | 3 +++ 3 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 packages/eslint-plugin/.eslintrc.js diff --git a/packages/eslint-plugin/.eslintrc.js b/packages/eslint-plugin/.eslintrc.js new file mode 100644 index 0000000000..aaf907cfbc --- /dev/null +++ b/packages/eslint-plugin/.eslintrc.js @@ -0,0 +1,35 @@ +/* + * Copyright 2023 The Backstage Authors + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// Custom lint config here since source is ES5 +module.exports = { + plugins: ['import'], + parserOptions: { + ecmaVersion: 5, + }, + rules: { + 'import/no-extraneous-dependencies': [ + 'error', + { + devDependencies: false, + optionalDependencies: true, + peerDependencies: true, + bundledDependencies: true, + }, + ], + 'no-unused-expressions': 'off', + }, +}; diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json index 9724cec32b..ee5e62c41e 100644 --- a/packages/eslint-plugin/package.json +++ b/packages/eslint-plugin/package.json @@ -12,5 +12,14 @@ "directory": "packages/eslint-plugin" }, "license": "Apache-2.0", - "main": "./index.js" + "main": "./index.js", + "scripts": { + "lint": "backstage-cli package lint" + }, + "dependencies": { + "@manypkg/get-packages": "^1.1.3" + }, + "devDependencies": { + "@backstage/cli": "workspace:^" + } } diff --git a/yarn.lock b/yarn.lock index ac5c6d0541..06cd22d84a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4098,6 +4098,9 @@ __metadata: "@backstage/eslint-plugin@workspace:packages/eslint-plugin": version: 0.0.0-use.local resolution: "@backstage/eslint-plugin@workspace:packages/eslint-plugin" + dependencies: + "@backstage/cli": "workspace:^" + "@manypkg/get-packages": ^1.1.3 languageName: unknown linkType: soft