refactor: rename permission to visibilityPermission

Signed-off-by: benjdlambert <ben@blam.sh>

packages/backend-defaults/src/alpha/entrypoints/actionsRegistry/DefaultActionsRegistryService.ts

@@ -148,9 +148,9 @@ export class DefaultActionsRegistryService implements ActionsRegistryService {
           throw new NotFoundError(`Action "${req.params.actionId}" not found`);
         }
 
-        if (action.permission) {
+        if (action.visibilityPermission) {
           const [decision] = await this.permissions.authorize(
-            [{ permission: action.permission }],
+            [{ permission: action.visibilityPermission }],
             { credentials },
           );
           if (decision.result === AuthorizeResult.DENY) {
@@ -204,8 +204,8 @@ export class DefaultActionsRegistryService implements ActionsRegistryService {
       throw new Error(`Action with id "${id}" is already registered`);
     }
 
-    if (options.permission) {
-      this.permissionsRegistry.addPermissions([options.permission]);
+    if (options.visibilityPermission) {
+      this.permissionsRegistry.addPermissions([options.visibilityPermission]);
     }
 
     this.actions.set(id, options);
@@ -216,7 +216,7 @@ export class DefaultActionsRegistryService implements ActionsRegistryService {
     credentials: BackstageCredentials,
   ): Promise<ActionEntry[]> {
     const permissionedEntries = entries.filter(
-      ([_, action]) => action.permission,
+      ([_, action]) => action.visibilityPermission,
     );
 
     if (permissionedEntries.length === 0) {
@@ -225,7 +225,7 @@ export class DefaultActionsRegistryService implements ActionsRegistryService {
 
     const decisions = await this.permissions.authorize(
       permissionedEntries.map(([_, action]) => ({
-        permission: action.permission!,
+        permission: action.visibilityPermission!,
       })),
       { credentials },
     );

packages/backend-defaults/src/alpha/entrypoints/actionsRegistry/actionsRegistryServiceFactory.test.ts

@@ -592,7 +592,7 @@ describe('actionsRegistryServiceFactory', () => {
                 name: 'protected-action',
                 title: 'Protected Action',
                 description: 'Permission required',
-                permission: testPermission,
+                visibilityPermission: testPermission,
                 schema: {
                   input: z => z.object({}),
                   output: z => z.object({}),
@@ -640,7 +640,7 @@ describe('actionsRegistryServiceFactory', () => {
                 name: 'protected-action',
                 title: 'Protected Action',
                 description: 'Permission required',
-                permission: testPermission,
+                visibilityPermission: testPermission,
                 schema: {
                   input: z => z.object({}),
                   output: z => z.object({}),
@@ -688,7 +688,7 @@ describe('actionsRegistryServiceFactory', () => {
                 name: 'protected-action',
                 title: 'Protected Action',
                 description: 'Permission required',
-                permission: testPermission,
+                visibilityPermission: testPermission,
                 schema: {
                   input: z => z.object({}),
                   output: z => z.object({}),
@@ -741,7 +741,7 @@ describe('actionsRegistryServiceFactory', () => {
                 name: 'protected-action',
                 title: 'Protected Action',
                 description: 'Permission required',
-                permission: testPermission,
+                visibilityPermission: testPermission,
                 schema: {
                   input: z => z.object({}),
                   output: z => z.object({ ok: z.boolean() }),
@@ -793,7 +793,7 @@ describe('actionsRegistryServiceFactory', () => {
                 name: 'protected-action',
                 title: 'Protected Action',
                 description: 'Permission required',
-                permission: testPermission,
+                visibilityPermission: testPermission,
                 schema: {
                   input: z => z.object({}),
                   output: z => z.object({}),
@@ -840,7 +840,7 @@ describe('actionsRegistryServiceFactory', () => {
                 name: 'protected-action',
                 title: 'Protected Action',
                 description: 'Permission required',
-                permission: testPermission,
+                visibilityPermission: testPermission,
                 schema: {
                   input: z => z.object({}),
                   output: z => z.object({}),

packages/backend-plugin-api/report-alpha.api.md

@@ -32,7 +32,7 @@ export type ActionsRegistryActionOptions<
     input: (zod: typeof z) => TInputSchema;
     output: (zod: typeof z) => TOutputSchema;
   };
-  permission?: BasicPermission;
+  visibilityPermission?: BasicPermission;
   attributes?: {
     destructive?: boolean;
     idempotent?: boolean;

packages/backend-plugin-api/src/alpha/ActionsRegistryService.ts

@@ -43,7 +43,7 @@ export type ActionsRegistryActionOptions<
     input: (zod: typeof z) => TInputSchema;
     output: (zod: typeof z) => TOutputSchema;
   };
-  permission?: BasicPermission;
+  visibilityPermission?: BasicPermission;
   attributes?: {
     destructive?: boolean;
     idempotent?: boolean;

packages/backend-plugin-api/src/services/definitions/ActionsRegistryService.ts

@@ -41,7 +41,7 @@ export type ActionsRegistryActionOptions<
     input: (zod: typeof z) => TInputSchema;
     output: (zod: typeof z) => TOutputSchema;
   };
-  permission?: BasicPermission;
+  visibilityPermission?: BasicPermission;
   attributes?: {
     destructive?: boolean;
     idempotent?: boolean;