From 9724084186b684053b76d8ab7393960f22545dd3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= <freben@gmail.com>
Date: Mon, 4 May 2020 16:42:40 +0200
Subject: [PATCH] It's InputError then

---
 packages/backend-common/src/errors.ts                       | 4 ++--
 packages/backend-common/src/middleware/errorHandler.test.ts | 6 +++---
 packages/backend-common/src/middleware/errorHandler.ts      | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/packages/backend-common/src/errors.ts b/packages/backend-common/src/errors.ts
index 34a605a576..b68dc8e3f0 100644
--- a/packages/backend-common/src/errors.ts
+++ b/packages/backend-common/src/errors.ts
@@ -48,9 +48,9 @@ class CustomErrorBase extends Error {
 }
 
 /**
- * The request is malformed and cannot be processed.
+ * The given inputs are malformed and cannot be processed.
  */
-export class BadRequestError extends CustomErrorBase {}
+export class InputError extends CustomErrorBase {}
 
 /**
  * The request requires authentication, which was not properly supplied.
diff --git a/packages/backend-common/src/middleware/errorHandler.test.ts b/packages/backend-common/src/middleware/errorHandler.test.ts
index d282ccb99b..022802dff8 100644
--- a/packages/backend-common/src/middleware/errorHandler.test.ts
+++ b/packages/backend-common/src/middleware/errorHandler.test.ts
@@ -49,8 +49,8 @@ describe('errorHandler', () => {
 
   it('handles well-known error classes', async () => {
     const app = express();
-    app.use('/BadRequestError', () => {
-      throw new errors.BadRequestError();
+    app.use('/InputError', () => {
+      throw new errors.InputError();
     });
     app.use('/AuthenticationError', () => {
       throw new errors.AuthenticationError();
@@ -67,7 +67,7 @@ describe('errorHandler', () => {
     app.use(errorHandler());
 
     const r = request(app);
-    expect((await r.get('/BadRequestError')).status).toBe(400);
+    expect((await r.get('/InputError')).status).toBe(400);
     expect((await r.get('/AuthenticationError')).status).toBe(401);
     expect((await r.get('/NotAllowedError')).status).toBe(403);
     expect((await r.get('/NotFoundError')).status).toBe(404);
diff --git a/packages/backend-common/src/middleware/errorHandler.ts b/packages/backend-common/src/middleware/errorHandler.ts
index 43782e4d7f..14f6cfa8d7 100644
--- a/packages/backend-common/src/middleware/errorHandler.ts
+++ b/packages/backend-common/src/middleware/errorHandler.ts
@@ -79,7 +79,7 @@ function getStatusCode(error: Error): number {
 
   // Handle well-known error types
   switch (error.name) {
-    case errors.BadRequestError.name:
+    case errors.InputError.name:
       return 400;
     case errors.AuthenticationError.name:
       return 401;