From 97157c547052fdd46e86c1a28f6c99387a3f89d7 Mon Sep 17 00:00:00 2001
From: blam <ben@blam.sh>
Date: Wed, 24 Jul 2024 11:51:52 +0200
Subject: [PATCH] chore: do not allow redefing types from blueprint in make
 config schema

Signed-off-by: blam <ben@blam.sh>
---
 .../wiring/createExtensionBlueprint.test.tsx  | 36 +++++++++++++++++++
 .../src/wiring/createExtensionBlueprint.ts    |  2 ++
 2 files changed, 38 insertions(+)

diff --git a/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.test.tsx b/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.test.tsx
index cf7de0fed3..209e9759bd 100644
--- a/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.test.tsx
+++ b/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.test.tsx
@@ -189,4 +189,40 @@ describe('createExtensionBlueprint', () => {
       },
     }).render();
   });
+
+  it('should not allow overlapping config keys', () => {
+    const TestExtensionBlueprint = createExtensionBlueprint({
+      kind: 'test-extension',
+      attachTo: { id: 'test', input: 'default' },
+      output: {
+        element: coreExtensionData.reactElement,
+      },
+      config: {
+        schema: {
+          text: z => z.string(),
+        },
+      },
+      factory(params: { text: string }) {
+        return {
+          element: <div>{params.text}</div>,
+        };
+      },
+    });
+
+    TestExtensionBlueprint.make({
+      name: 'my-extension',
+      params: {
+        text: 'Hello, world!',
+      },
+      config: {
+        schema: {
+          // @ts-expect-error
+          text: z => z.number(),
+          something: z => z.string(),
+        },
+      },
+    });
+
+    expect('test').toBe('test');
+  });
 });
diff --git a/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.ts b/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.ts
index 56edcd8141..21c10f3c0e 100644
--- a/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.ts
+++ b/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.ts
@@ -92,6 +92,8 @@ export interface ExtensionBlueprint<
           [key in keyof TExtensionConfigSchema]: (
             zImpl: typeof z,
           ) => TExtensionConfigSchema[key];
+        } & {
+          [key in keyof TConfig]?: never;
         };
       };
     } & (