Minor fixes from last round of review.

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
This commit is contained in:
Eric Peterson
2021-05-13 16:16:42 +02:00
parent c729b520bb
commit 96e3be74c2
2 changed files with 3 additions and 2 deletions
+2 -1
View File
@@ -92,7 +92,8 @@ export class DefaultCacheClient implements CacheClient {
const wellFormedKey = Buffer.from(candidateKey).toString('base64');
// Memcache in particular doesn't do well with keys > 250 bytes.
if (wellFormedKey.length < 250) {
// Padded because a plugin ID is also prepended to the key.
if (wellFormedKey.length < 200) {
return wellFormedKey;
}
+1 -1
View File
@@ -65,7 +65,7 @@ export class CacheManager {
}
/**
* Generates a CacheManagerInstance for consumption by plugins.
* Generates a PluginCacheManager for consumption by plugins.
*
* @param pluginId The plugin that the cache manager should be created for. Plugin names should be unique.
*/