From 966e3760568a78244cde48d8f6511ec1f4e5bf5c Mon Sep 17 00:00:00 2001
From: Vincenzo Scamporlino <vincenzos@spotify.com>
Date: Thu, 10 Aug 2023 23:41:24 +0200
Subject: [PATCH] backend-app-api: rename services option to
 defaultServiceFactories

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
---
 .../src/wiring/createSpecializedBackend.test.ts           | 8 +++++---
 .../src/wiring/createSpecializedBackend.ts                | 2 +-
 packages/backend-app-api/src/wiring/types.ts              | 2 +-
 .../backend-test-utils/src/next/wiring/TestBackend.ts     | 6 +++++-
 4 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/packages/backend-app-api/src/wiring/createSpecializedBackend.test.ts b/packages/backend-app-api/src/wiring/createSpecializedBackend.test.ts
index dc9a0cc085..1fd7fcbbec 100644
--- a/packages/backend-app-api/src/wiring/createSpecializedBackend.test.ts
+++ b/packages/backend-app-api/src/wiring/createSpecializedBackend.test.ts
@@ -22,13 +22,15 @@ import { createSpecializedBackend } from './createSpecializedBackend';
 
 describe('createSpecializedBackend', () => {
   it('should create a backend without services', () => {
-    expect(() => createSpecializedBackend({ services: [] })).not.toThrow();
+    expect(() =>
+      createSpecializedBackend({ defaultServiceFactories: [] }),
+    ).not.toThrow();
   });
 
   it('should throw on duplicate service implementations', () => {
     expect(() =>
       createSpecializedBackend({
-        services: [
+        defaultServiceFactories: [
           createServiceFactory({
             service: coreServices.rootLifecycle,
             deps: {},
@@ -55,7 +57,7 @@ describe('createSpecializedBackend', () => {
   it('should throw when providing a plugin metadata service implementation', () => {
     expect(() =>
       createSpecializedBackend({
-        services: [
+        defaultServiceFactories: [
           createServiceFactory({
             service: coreServices.pluginMetadata,
             deps: {},
diff --git a/packages/backend-app-api/src/wiring/createSpecializedBackend.ts b/packages/backend-app-api/src/wiring/createSpecializedBackend.ts
index 15e51f7c4c..f5c4d8b152 100644
--- a/packages/backend-app-api/src/wiring/createSpecializedBackend.ts
+++ b/packages/backend-app-api/src/wiring/createSpecializedBackend.ts
@@ -24,7 +24,7 @@ import { Backend, CreateSpecializedBackendOptions } from './types';
 export function createSpecializedBackend(
   options: CreateSpecializedBackendOptions,
 ): Backend {
-  const services = options.services.map(sf =>
+  const services = options.defaultServiceFactories.map(sf =>
     typeof sf === 'function' ? sf() : sf,
   );
 
diff --git a/packages/backend-app-api/src/wiring/types.ts b/packages/backend-app-api/src/wiring/types.ts
index ffedb40324..36e2dede30 100644
--- a/packages/backend-app-api/src/wiring/types.ts
+++ b/packages/backend-app-api/src/wiring/types.ts
@@ -34,7 +34,7 @@ export interface Backend {
  * @public
  */
 export interface CreateSpecializedBackendOptions {
-  services: ServiceFactoryOrFunction[];
+  defaultServiceFactories: ServiceFactoryOrFunction[];
 }
 
 export interface ServiceHolder {
diff --git a/packages/backend-test-utils/src/next/wiring/TestBackend.ts b/packages/backend-test-utils/src/next/wiring/TestBackend.ts
index 06e27e5c07..0bade8bfbb 100644
--- a/packages/backend-test-utils/src/next/wiring/TestBackend.ts
+++ b/packages/backend-test-utils/src/next/wiring/TestBackend.ts
@@ -279,7 +279,11 @@ export async function startTestBackend<
 
   const backend = createSpecializedBackend({
     ...otherOptions,
-    services: [...factories, rootHttpRouterFactory, discoveryFactory],
+    defaultServiceFactories: [
+      ...factories,
+      rootHttpRouterFactory,
+      discoveryFactory,
+    ],
   });
 
   backendInstancesToCleanUp.push(backend);