From 96081d960a6b441bde8c8d0e80de2c595bfd6b5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Fri, 19 Aug 2022 14:49:13 +0200 Subject: [PATCH] newrelic MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- plugins/newrelic-dashboard/api-report.md | 2 -- plugins/newrelic-dashboard/src/Router.tsx | 1 + plugins/newrelic-dashboard/src/index.ts | 1 + plugins/newrelic/api-report.md | 4 ---- plugins/newrelic/src/plugin.ts | 2 ++ scripts/api-extractor.ts | 2 -- 6 files changed, 4 insertions(+), 8 deletions(-) diff --git a/plugins/newrelic-dashboard/api-report.md b/plugins/newrelic-dashboard/api-report.md index 223a327d20..740fc46ef7 100644 --- a/plugins/newrelic-dashboard/api-report.md +++ b/plugins/newrelic-dashboard/api-report.md @@ -22,8 +22,6 @@ export const EntityNewRelicDashboardCard: () => JSX.Element; // @public (undocumented) export const EntityNewRelicDashboardContent: () => JSX.Element; -// Warning: (ae-missing-release-tag) "isNewRelicDashboardAvailable" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) -// // @public (undocumented) export const isNewRelicDashboardAvailable: (entity: Entity) => boolean; diff --git a/plugins/newrelic-dashboard/src/Router.tsx b/plugins/newrelic-dashboard/src/Router.tsx index 24a5a1037f..b549d1107b 100644 --- a/plugins/newrelic-dashboard/src/Router.tsx +++ b/plugins/newrelic-dashboard/src/Router.tsx @@ -21,6 +21,7 @@ import { NewRelicDashboard } from './components/NewRelicDashboard'; import { useEntity } from '@backstage/plugin-catalog-react'; import { NEWRELIC_GUID_ANNOTATION } from './constants'; +/** @public */ export const isNewRelicDashboardAvailable = (entity: Entity) => Boolean(entity?.metadata?.annotations?.[NEWRELIC_GUID_ANNOTATION]); diff --git a/plugins/newrelic-dashboard/src/index.ts b/plugins/newrelic-dashboard/src/index.ts index 060306524f..ba87b8a514 100644 --- a/plugins/newrelic-dashboard/src/index.ts +++ b/plugins/newrelic-dashboard/src/index.ts @@ -13,6 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + export { newRelicDashboardPlugin, EntityNewRelicDashboardCard, diff --git a/plugins/newrelic/api-report.md b/plugins/newrelic/api-report.md index fbf639ee9d..302b7c918a 100644 --- a/plugins/newrelic/api-report.md +++ b/plugins/newrelic/api-report.md @@ -8,13 +8,9 @@ import { BackstagePlugin } from '@backstage/core-plugin-api'; import { RouteRef } from '@backstage/core-plugin-api'; -// Warning: (ae-missing-release-tag) "NewRelicPage" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) -// // @public (undocumented) export const NewRelicPage: () => JSX.Element; -// Warning: (ae-missing-release-tag) "newRelicPlugin" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) -// // @public (undocumented) const newRelicPlugin: BackstagePlugin< { diff --git a/plugins/newrelic/src/plugin.ts b/plugins/newrelic/src/plugin.ts index 6cf77a785f..0387c50aa9 100644 --- a/plugins/newrelic/src/plugin.ts +++ b/plugins/newrelic/src/plugin.ts @@ -27,6 +27,7 @@ export const rootRouteRef = createRouteRef({ id: 'newrelic', }); +/** @public */ export const newRelicPlugin = createPlugin({ id: 'newrelic', apis: [ @@ -41,6 +42,7 @@ export const newRelicPlugin = createPlugin({ }, }); +/** @public */ export const NewRelicPage = newRelicPlugin.provide( createRoutableExtension({ name: 'NewRelicPage', diff --git a/scripts/api-extractor.ts b/scripts/api-extractor.ts index 19fbfd79be..61f304730f 100644 --- a/scripts/api-extractor.ts +++ b/scripts/api-extractor.ts @@ -212,8 +212,6 @@ const ALLOW_WARNINGS = [ 'plugins/jenkins-backend', 'plugins/kubernetes', 'plugins/kubernetes-common', - 'plugins/newrelic', - 'plugins/newrelic-dashboard', ]; async function resolvePackagePath(