From 50b9eba922252356adff7356abb73ab65c9fe81f Mon Sep 17 00:00:00 2001 From: blam Date: Tue, 1 Jun 2021 14:22:08 +0200 Subject: [PATCH 1/2] chore: update the github app id config schema Signed-off-by: blam --- packages/integration/config.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/integration/config.d.ts b/packages/integration/config.d.ts index ddc84ae011..73ce43e001 100644 --- a/packages/integration/config.d.ts +++ b/packages/integration/config.d.ts @@ -89,9 +89,9 @@ export interface Config { */ apps?: Array<{ /** - * The numeric GitHub App ID + * The numeric GitHub App ID, string for environment variables */ - appId: number; + appId: number | string; /** * The private key to use for auth against the app * @visibility secret From 49d7ec1694a040d1b481e4dbb8eeea76ed50642e Mon Sep 17 00:00:00 2001 From: blam Date: Tue, 1 Jun 2021 14:24:20 +0200 Subject: [PATCH 2/2] chore: fix vale errors Signed-off-by: blam --- .changeset/mean-tigers-brake.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/mean-tigers-brake.md diff --git a/.changeset/mean-tigers-brake.md b/.changeset/mean-tigers-brake.md new file mode 100644 index 0000000000..07871a590b --- /dev/null +++ b/.changeset/mean-tigers-brake.md @@ -0,0 +1,5 @@ +--- +'@backstage/integration': patch +--- + +GitHub App ID can be a string too for environment variables otherwise it will fail validation