From 94cc3dbf48966a48fd8898b4eb7e86921cd55836 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 20 Feb 2025 14:52:05 +0100 Subject: [PATCH] catalog-react: align defaultFilter config naming Signed-off-by: Patrik Oldsberg --- plugins/catalog-react/report-alpha.api.md | 2 +- .../alpha/blueprints/EntityCardLauyoutBlueprint.tsx | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/plugins/catalog-react/report-alpha.api.md b/plugins/catalog-react/report-alpha.api.md index 22806998fd..e47a01eeae 100644 --- a/plugins/catalog-react/report-alpha.api.md +++ b/plugins/catalog-react/report-alpha.api.md @@ -175,7 +175,7 @@ export const EntityCardLayoutBlueprint: ExtensionBlueprint<{ kind: 'entity-card-layout'; name: undefined; params: { - defaultFilter?: string | ((entity: Entity) => boolean) | undefined; + filter?: string | ((entity: Entity) => boolean) | undefined; loader: () => Promise< (props: EntityCardLayoutProps) => React_2.JSX.Element >; diff --git a/plugins/catalog-react/src/alpha/blueprints/EntityCardLauyoutBlueprint.tsx b/plugins/catalog-react/src/alpha/blueprints/EntityCardLauyoutBlueprint.tsx index 3aaba93813..13b1d8c7d8 100644 --- a/plugins/catalog-react/src/alpha/blueprints/EntityCardLauyoutBlueprint.tsx +++ b/plugins/catalog-react/src/alpha/blueprints/EntityCardLauyoutBlueprint.tsx @@ -63,9 +63,9 @@ export const EntityCardLayoutBlueprint = createExtensionBlueprint({ *factory( { loader, - defaultFilter, + filter, }: { - defaultFilter?: + filter?: | typeof entityFilterFunctionDataRef.T | typeof entityFilterExpressionDataRef.T; loader: () => Promise< @@ -76,10 +76,10 @@ export const EntityCardLayoutBlueprint = createExtensionBlueprint({ ) { if (config.filter) { yield entityFilterExpressionDataRef(config.filter); - } else if (typeof defaultFilter === 'string') { - yield entityFilterExpressionDataRef(defaultFilter); - } else if (typeof defaultFilter === 'function') { - yield entityFilterFunctionDataRef(defaultFilter); + } else if (typeof filter === 'string') { + yield entityFilterExpressionDataRef(filter); + } else if (typeof filter === 'function') { + yield entityFilterFunctionDataRef(filter); } const ExtensionComponent = reactLazy(() =>