From 94b4ab688d9a0b1f864cffab89c451bf525551f7 Mon Sep 17 00:00:00 2001
From: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
Date: Thu, 29 Dec 2022 17:06:33 +0530
Subject: [PATCH] refactor: simplify coersion of type to string

Co-authored-by: Ben Lambert <blam@spotify.com>
Signed-off-by: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
---
 packages/config/src/reader.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/packages/config/src/reader.ts b/packages/config/src/reader.ts
index 95924c45da..fe3a8dbeaa 100644
--- a/packages/config/src/reader.ts
+++ b/packages/config/src/reader.ts
@@ -290,10 +290,12 @@ export class ConfigReader implements Config {
     if (typeof value === 'boolean' || value === undefined) {
       return value;
     }
-    if (/^(?:y|yes|true|1|on)$/i.test(value as string) || value === 1) {
+   const valueString = String(value).trim();
+   
+    if (/^(?:y|yes|true|1|on)$/i.test(valueString)) {
       return true;
     }
-    if (/^(?:n|no|false|0|off)$/i.test(value as string) || value === 0) {
+    if (/^(?:n|no|false|0|off)$/i.test(valueString)) {
       return false;
     }
     throw new Error(errors.convert(this.fullKey(key), this.context, 'boolean'));