From 9314a859267a1a974ba4bfff74e31bcd86d9e1c5 Mon Sep 17 00:00:00 2001 From: jrusso1020 Date: Mon, 3 May 2021 09:21:55 -0600 Subject: [PATCH] Close eventstreams upon completion Previously we were not closing eventSource's upon completion which lead to stale eventstream calls persisting across a session in the scaffolder. This calls eventSource.close() properly in order to clean up an eventStream once we get completion event Signed-off-by: jrusso1020 --- .changeset/tame-masks-juggle.md | 5 +++++ plugins/scaffolder/src/api.ts | 1 + 2 files changed, 6 insertions(+) create mode 100644 .changeset/tame-masks-juggle.md diff --git a/.changeset/tame-masks-juggle.md b/.changeset/tame-masks-juggle.md new file mode 100644 index 0000000000..91ee43945a --- /dev/null +++ b/.changeset/tame-masks-juggle.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder': patch +--- + +Close eventSource upon completion of a scaffolder task diff --git a/plugins/scaffolder/src/api.ts b/plugins/scaffolder/src/api.ts index 6caa2a4446..0c5eb2b268 100644 --- a/plugins/scaffolder/src/api.ts +++ b/plugins/scaffolder/src/api.ts @@ -214,6 +214,7 @@ export class ScaffolderClient implements ScaffolderApi { subscriber.error(ex); } } + eventSource.close(); subscriber.complete(); }); eventSource.addEventListener('error', event => {