From 8e025f13470a7d11a59a8173ab9b8af68814d30a Mon Sep 17 00:00:00 2001 From: Diego Bardari Date: Wed, 11 Jan 2023 16:40:16 +0100 Subject: [PATCH 1/2] Added support for externalId when assuming role in AwsS3EntityProvider Signed-off-by: Diego Bardari --- .changeset/lemon-tables-train.md | 5 +++++ .../src/credentials/AwsCredentials.ts | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 .changeset/lemon-tables-train.md diff --git a/.changeset/lemon-tables-train.md b/.changeset/lemon-tables-train.md new file mode 100644 index 0000000000..39208a5edf --- /dev/null +++ b/.changeset/lemon-tables-train.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog-backend-module-aws': patch +--- + +Added support for externalId when assuming role in AwsS3EntityProvider diff --git a/plugins/catalog-backend-module-aws/src/credentials/AwsCredentials.ts b/plugins/catalog-backend-module-aws/src/credentials/AwsCredentials.ts index ffb84d1c34..fded78aed4 100644 --- a/plugins/catalog-backend-module-aws/src/credentials/AwsCredentials.ts +++ b/plugins/catalog-backend-module-aws/src/credentials/AwsCredentials.ts @@ -27,6 +27,7 @@ export class AwsCredentials { accessKeyId?: string; secretAccessKey?: string; roleArn?: string; + externalId?: string; }, roleSessionName: string, ): Credentials | CredentialsOptions | undefined { @@ -52,6 +53,7 @@ export class AwsCredentials { params: { RoleArn: roleArn, RoleSessionName: roleSessionName, + ExternalId: config.externalId, }, }); } From bd12666dab3b2f01a761bc6da81291e5c24bf9e4 Mon Sep 17 00:00:00 2001 From: blam Date: Mon, 23 Jan 2023 16:02:23 +0100 Subject: [PATCH 2/2] chore: fixing the formatting in the changeset Signed-off-by: blam --- .changeset/lemon-tables-train.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/lemon-tables-train.md b/.changeset/lemon-tables-train.md index 39208a5edf..80b64bfe53 100644 --- a/.changeset/lemon-tables-train.md +++ b/.changeset/lemon-tables-train.md @@ -2,4 +2,4 @@ '@backstage/plugin-catalog-backend-module-aws': patch --- -Added support for externalId when assuming role in AwsS3EntityProvider +Added support for `externalId` when assuming role in `AwsS3EntityProvider`