From 9227f4e38d9fde5b2578689192d600eb8c68a412 Mon Sep 17 00:00:00 2001
From: Vincenzo Scamporlino <vincenzos@spotify.com>
Date: Tue, 18 Jul 2023 10:38:04 +0200
Subject: [PATCH] cli: avoid global object

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
---
 packages/cli/src/lib/bundler/config.ts | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/packages/cli/src/lib/bundler/config.ts b/packages/cli/src/lib/bundler/config.ts
index df3f440fa5..e732377a4d 100644
--- a/packages/cli/src/lib/bundler/config.ts
+++ b/packages/cli/src/lib/bundler/config.ts
@@ -40,7 +40,6 @@ import pickBy from 'lodash/pickBy';
 import yn from 'yn';
 import { readEntryPoints } from '../entryPoints';
 
-const PACKAGES_GLOBAL = '__backstage_detected_packages__';
 const BUILD_CACHE_ENV_VAR = 'BACKSTAGE_CLI_EXPERIMENTAL_BUILD_CACHE';
 
 export function resolveBaseUrl(config: Config): URL {
@@ -136,7 +135,7 @@ export async function createConfig(
 
     plugins.push(
       new VirtualModulesPlugin({
-        [`node_modules/${PACKAGES_GLOBAL}.js`]: `window['${PACKAGES_GLOBAL}'] = { modules: [${requirePackageScript}] }`,
+        'node_modules/backstage-autodetected-plugins.js': `module.exports = { modules: [${requirePackageScript}] };`,
       }),
     );
   }
@@ -178,7 +177,9 @@ export async function createConfig(
     devtool: isDev ? 'eval-cheap-module-source-map' : 'source-map',
     context: paths.targetPath,
     entry: [
-      ...(extraPackages.length > 0 ? [`${PACKAGES_GLOBAL}.js`] : []),
+      ...(extraPackages.length > 0
+        ? [`backstage-autodetected-plugins.js`]
+        : []),
       paths.targetEntry,
     ],
     resolve: {