diff --git a/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.test.ts b/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.test.ts index 8d5e9674ca..5c33e9e369 100644 --- a/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.test.ts +++ b/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.test.ts @@ -142,16 +142,14 @@ const latestSchemasMock = jest.fn().mockImplementation(() => [ }, ]); const factsBetweenTimestampsByIdsMock = jest.fn(); -const latestFactsByIdsMock = jest.fn().mockImplementation(() => - Promise.resolve({ - ['test-factretriever']: { - id: 'test-factretriever', - facts: { - testnumberfact: 3, - }, +const latestFactsByIdsMock = jest.fn().mockResolvedValue({ + ['test-factretriever']: { + id: 'test-factretriever', + facts: { + testnumberfact: 3, }, - }), -); + }, +}); const mockCheckRegistry = { getAll(checks: string[]) { return checks.flatMap(check => testChecks[check]); diff --git a/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.ts b/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.ts index 44087698ab..640ad51113 100644 --- a/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.ts +++ b/plugins/tech-insights-backend-module-jsonfc/src/service/JsonRulesEngineFactChecker.ts @@ -90,7 +90,7 @@ export class JsonRulesEngineFactChecker rule.name = techInsightCheck.id; // Only run checks that have all the facts available: const hasAllFacts = techInsightCheck.factIds.every( - retrieverId => !!facts[retrieverId], + factId => !!facts[factId], ); if (hasAllFacts) { engine.addRule({ ...techInsightCheck.rule, event: noopEvent });