Set a pagination-aware rank value for all search engines.

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-06-09 15:17:55 +02:00
parent 484afdf1dc
commit 915700f64f
12 changed files with 102 additions and 32 deletions
@@ -189,10 +189,15 @@ export class AuthorizedSearchEngine implements SearchEngine {
    );

    return {
-      results: filteredResults.slice(
-        page * this.pageSize,
-        (page + 1) * this.pageSize,
-      ),
+      results: filteredResults
+        .slice(page * this.pageSize, (page + 1) * this.pageSize)
+        .map((result, index) => {
+          // Overwrite any/all rank entries to avoid leaking knowledge of filtered results.
+          return {
+            ...result,
+            rank: page * this.pageSize + index + 1,
+          };
+        }),
      previousPageCursor:
        page === 0 ? undefined : encodePageCursor({ page: page - 1 }),
      nextPageCursor: