From 9155138168be2014c2b17ed831f00c6345b65718 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Sat, 19 Sep 2020 15:21:43 +0200
Subject: [PATCH] core-api/routing: make RouteRef implement ConcreteRoute and
 use in registry test

---
 packages/core-api/src/routing/RouteRef.ts           |  8 ++++++--
 .../core-api/src/routing/RouteRefRegistry.test.ts   | 13 +++++++------
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/packages/core-api/src/routing/RouteRef.ts b/packages/core-api/src/routing/RouteRef.ts
index 8a03680791..cc36446f8b 100644
--- a/packages/core-api/src/routing/RouteRef.ts
+++ b/packages/core-api/src/routing/RouteRef.ts
@@ -14,9 +14,9 @@
  * limitations under the License.
  */
 
-import type { RouteRefConfig } from './types';
+import { ConcreteRoute, resolveRoute, RouteRefConfig } from './types';
 
-export class AbsoluteRouteRef {
+export class AbsoluteRouteRef implements ConcreteRoute {
   constructor(private readonly config: RouteRefConfig) {}
 
   get icon() {
@@ -31,6 +31,10 @@ export class AbsoluteRouteRef {
   get title() {
     return this.config.title;
   }
+
+  [resolveRoute](path: string) {
+    return path;
+  }
 }
 
 export function createRouteRef(config: RouteRefConfig): AbsoluteRouteRef {
diff --git a/packages/core-api/src/routing/RouteRefRegistry.test.ts b/packages/core-api/src/routing/RouteRefRegistry.test.ts
index 76272cb9f7..91bbc70117 100644
--- a/packages/core-api/src/routing/RouteRefRegistry.test.ts
+++ b/packages/core-api/src/routing/RouteRefRegistry.test.ts
@@ -15,13 +15,14 @@
  */
 
 import { RouteRefRegistry } from './RouteRefRegistry';
-import { resolveRoute } from './types';
+import { createRouteRef } from './RouteRef';
 
-const ref1 = { [resolveRoute]: (path: string) => path };
-const ref11 = { [resolveRoute]: (path: string) => path };
-const ref12 = { [resolveRoute]: (path: string) => path };
-const ref121 = { [resolveRoute]: (path: string) => path };
-const ref2 = { [resolveRoute]: (path: string) => path };
+const dummyConfig = { path: '/', icon: null, title: 'my-title' };
+const ref1 = createRouteRef(dummyConfig);
+const ref11 = createRouteRef(dummyConfig);
+const ref12 = createRouteRef(dummyConfig);
+const ref121 = createRouteRef(dummyConfig);
+const ref2 = createRouteRef(dummyConfig);
 
 describe('RouteRefRegistry', () => {
   it('should be constructed with a root route', () => {