From 1be5ad66996571f8ad23d1f9e4432c15cb87ff07 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dejan=20Belu=C5=A1i=C4=87?= <dejanbelusic@gmail.com>
Date: Tue, 26 Nov 2024 10:44:13 +0100
Subject: [PATCH 1/5] Update 'DescriptionFieldTemplate' component to open links
 in new tab.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Dejan Belušić <dejanbelusic@gmail.com>
---
 .../src/next/components/Form/DescriptionFieldTemplate.tsx        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/plugins/scaffolder-react/src/next/components/Form/DescriptionFieldTemplate.tsx b/plugins/scaffolder-react/src/next/components/Form/DescriptionFieldTemplate.tsx
index 7731cac3f8..5f12e0f1a3 100644
--- a/plugins/scaffolder-react/src/next/components/Form/DescriptionFieldTemplate.tsx
+++ b/plugins/scaffolder-react/src/next/components/Form/DescriptionFieldTemplate.tsx
@@ -56,6 +56,7 @@ export const DescriptionFieldTemplate = <
       return (
         <MarkdownContent
           content={description}
+          linkTarget="_blank"
           className={classes.markdownDescription}
         />
       );

From 94852d23176657e91ffa65bfde24f1e1e58a5d97 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dejan=20Belu=C5=A1i=C4=87?= <dejanbelusic@gmail.com>
Date: Tue, 26 Nov 2024 10:45:43 +0100
Subject: [PATCH 2/5] Update 'Workflow' component
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Open link in the description in the new tab.

Signed-off-by: Dejan Belušić <dejanbelusic@gmail.com>
---
 .../scaffolder-react/src/next/components/Workflow/Workflow.tsx   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/plugins/scaffolder-react/src/next/components/Workflow/Workflow.tsx b/plugins/scaffolder-react/src/next/components/Workflow/Workflow.tsx
index 9afc18c438..31f5ac2881 100644
--- a/plugins/scaffolder-react/src/next/components/Workflow/Workflow.tsx
+++ b/plugins/scaffolder-react/src/next/components/Workflow/Workflow.tsx
@@ -121,6 +121,7 @@ export const Workflow = (workflowProps: WorkflowProps): JSX.Element | null => {
           subheader={
             <MarkdownContent
               className={styles.markdown}
+              linkTarget="_blank"
               content={
                 description ?? sortedManifest.description ?? 'No description'
               }

From dbbe1415cf6937f2955e3a8c0e6f1af1c712659b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dejan=20Belu=C5=A1i=C4=87?= <dejanbelusic@gmail.com>
Date: Tue, 26 Nov 2024 11:13:35 +0100
Subject: [PATCH 3/5] Add a test to 'MarkdownContent' component to check if
 link target it set to '_blank'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Dejan Belušić <dejanbelusic@gmail.com>
---
 .../MarkdownContent/MarkdownContent.test.tsx    | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/packages/core-components/src/components/MarkdownContent/MarkdownContent.test.tsx b/packages/core-components/src/components/MarkdownContent/MarkdownContent.test.tsx
index d9d82437e4..21b576dd9f 100644
--- a/packages/core-components/src/components/MarkdownContent/MarkdownContent.test.tsx
+++ b/packages/core-components/src/components/MarkdownContent/MarkdownContent.test.tsx
@@ -120,6 +120,23 @@ describe('<MarkdownContent />', () => {
     );
   });
 
+  it('render MarkdownContent component with link target set to _blank', async () => {
+    await renderInTestApp(
+      <MarkdownContent
+        content="Take a look at the [README](https://github.com/backstage/backstage/blob/master/README.md) file."
+        linkTarget="_blank"
+      />,
+    );
+    const readme = screen.getByText('README', {
+      selector: 'a',
+    });
+    expect(readme).toBeInTheDocument();
+    expect(readme.getAttribute('href')).toEqual(
+      'https://github.com/backstage/backstage/blob/master/README.md',
+    );
+    expect(readme.getAttribute('target')).toEqual('_blank');
+  });
+
   it('render MarkdownContent component with headings given proper ids', async () => {
     await renderInTestApp(
       <MarkdownContent

From b21a5aed6afcc590716354d66aeea8cc1bf88176 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dejan=20Belu=C5=A1i=C4=87?= <dejanbelusic@gmail.com>
Date: Tue, 26 Nov 2024 11:31:57 +0100
Subject: [PATCH 4/5] Create warm-pumpkins-bathe.md
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Dejan Belušić <dejanbelusic@gmail.com>
---
 .changeset/warm-pumpkins-bathe.md | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 .changeset/warm-pumpkins-bathe.md

diff --git a/.changeset/warm-pumpkins-bathe.md b/.changeset/warm-pumpkins-bathe.md
new file mode 100644
index 0000000000..0f04e7001e
--- /dev/null
+++ b/.changeset/warm-pumpkins-bathe.md
@@ -0,0 +1,6 @@
+---
+'@backstage/core-components': patch
+'@backstage/plugin-scaffolder-react': patch
+---
+
+Open links in the scaffolder entity and step descriptions in a new tab, to ensure consistency and improve user experience

From b320ead306919d25ebc51f76f7c9004f0a793904 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dejan=20Belu=C5=A1i=C4=87?= <dejan.belusic@rabobank.nl>
Date: Tue, 26 Nov 2024 15:32:59 +0100
Subject: [PATCH 5/5] Update the changeset because changes to tests do not
 require changesets.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Dejan Belušić <dejanbelusic@gmail.com>
---
 .changeset/warm-pumpkins-bathe.md | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.changeset/warm-pumpkins-bathe.md b/.changeset/warm-pumpkins-bathe.md
index 0f04e7001e..93fa603342 100644
--- a/.changeset/warm-pumpkins-bathe.md
+++ b/.changeset/warm-pumpkins-bathe.md
@@ -1,5 +1,4 @@
 ---
-'@backstage/core-components': patch
 '@backstage/plugin-scaffolder-react': patch
 ---