review comments

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
This commit is contained in:
Fredrik Adelöw
2021-09-28 10:13:45 +02:00
parent c8dc80bf49
commit 8fdd2eab89
2 changed files with 15 additions and 8 deletions
@@ -33,13 +33,12 @@ export type Props = {
const useStyles = makeStyles<Theme>(theme => ({
quadrantLegend: {
overflowY: 'scroll',
overflowY: 'auto',
scrollbarWidth: 'thin',
},
quadrant: {
height: '100%',
width: '100%',
overflow: 'scroll',
scrollbarWidth: 'thin',
pointerEvents: 'none',
},
@@ -188,8 +187,12 @@ const RadarLegend = (props: Props): JSX.Element => {
<li
key={entry.id}
value={(entry.index || 0) + 1}
onMouseEnter={() => onEntryMouseEnter?.(entry)}
onMouseLeave={() => onEntryMouseLeave?.(entry)}
onMouseEnter={
onEntryMouseEnter && (() => onEntryMouseEnter(entry))
}
onMouseLeave={
onEntryMouseLeave && (() => onEntryMouseLeave(entry))
}
>
<RadarLegendLink
url={entry.url}
@@ -55,8 +55,12 @@ const RadarPlot = (props: Props): JSX.Element => {
quadrants={quadrants}
rings={rings}
entries={entries}
onEntryMouseEnter={entry => onEntryMouseEnter?.(entry)}
onEntryMouseLeave={entry => onEntryMouseLeave?.(entry)}
onEntryMouseEnter={
onEntryMouseEnter && (entry => onEntryMouseEnter(entry))
}
onEntryMouseLeave={
onEntryMouseLeave && (entry => onEntryMouseLeave(entry))
}
/>
<g transform={`translate(${width / 2}, ${height / 2})`}>
<RadarGrid radius={radius} rings={rings} />
@@ -72,8 +76,8 @@ const RadarPlot = (props: Props): JSX.Element => {
description={entry.description}
moved={entry.moved}
title={entry.title}
onMouseEnter={() => onEntryMouseEnter?.(entry)}
onMouseLeave={() => onEntryMouseLeave?.(entry)}
onMouseEnter={onEntryMouseEnter && (() => onEntryMouseEnter(entry))}
onMouseLeave={onEntryMouseLeave && (() => onEntryMouseLeave(entry))}
/>
))}
<RadarBubble