From 8eca9492504d515b8e428a5db3874292859f4b99 Mon Sep 17 00:00:00 2001
From: elonj <elonj@spotify.com>
Date: Thu, 7 Jul 2022 15:09:51 -0400
Subject: [PATCH] clean up

Signed-off-by: elonj <elonj@spotify.com>
---
 plugins/catalog-backend/src/util/metrics.ts | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/plugins/catalog-backend/src/util/metrics.ts b/plugins/catalog-backend/src/util/metrics.ts
index 8edc721914..207135f234 100644
--- a/plugins/catalog-backend/src/util/metrics.ts
+++ b/plugins/catalog-backend/src/util/metrics.ts
@@ -31,9 +31,8 @@ export function createCounterMetric<T extends string>(
 ): Counter<T> {
   let metric = register.getSingleMetric(config.name);
   if (!metric) {
-    const newMetric = new Counter<T>(config);
-    register.registerMetric(newMetric);
-    metric = register.getSingleMetric(config.name);
+    metric = new Counter<T>(config);
+    register.registerMetric(metric);
   }
   return metric as Counter<T>;
 }
@@ -43,9 +42,8 @@ export function createGaugeMetric<T extends string>(
 ): Gauge<T> {
   let metric = register.getSingleMetric(config.name);
   if (!metric) {
-    const newMetric = new Gauge<T>(config);
-    register.registerMetric(newMetric);
-    metric = register.getSingleMetric(config.name);
+    metric = new Gauge<T>(config);
+    register.registerMetric(metric);
   }
   return metric as Gauge<T>;
 }
@@ -55,9 +53,8 @@ export function createSummaryMetric<T extends string>(
 ): Summary<T> {
   let metric = register.getSingleMetric(config.name);
   if (!metric) {
-    const newMetric = new Summary<T>(config);
-    register.registerMetric(newMetric);
-    metric = register.getSingleMetric(config.name);
+    metric = new Summary<T>(config);
+    register.registerMetric(metric);
   }
 
   return metric as Summary<T>;
@@ -68,9 +65,8 @@ export function createHistogramMetric<T extends string>(
 ): Histogram<T> {
   let metric = register.getSingleMetric(config.name);
   if (!metric) {
-    const newMetric = new Histogram<T>(config);
-    register.registerMetric(newMetric);
-    metric = register.getSingleMetric(config.name);
+    metric = new Histogram<T>(config);
+    register.registerMetric(metric);
   }
 
   return metric as Histogram<T>;