From 8d472c89e166484ab25e47729242a494d5a6f33f Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Tue, 17 Sep 2024 13:11:13 +0200 Subject: [PATCH] app-backend: escape script tag endings in config Signed-off-by: Patrik Oldsberg --- .../lib/config/injectConfigIntoHtml.test.ts | 29 +++++++++++++++++++ .../src/lib/config/injectConfigIntoHtml.ts | 9 +++++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/plugins/app-backend/src/lib/config/injectConfigIntoHtml.test.ts b/plugins/app-backend/src/lib/config/injectConfigIntoHtml.test.ts index f4f2655f1c..56c916fbb9 100644 --- a/plugins/app-backend/src/lib/config/injectConfigIntoHtml.test.ts +++ b/plugins/app-backend/src/lib/config/injectConfigIntoHtml.test.ts @@ -67,6 +67,35 @@ describe('injectConfigIntoHtml', () => { } ] +`, + }); + }); + + it('should trim script tag endings from injected config', async () => { + mockDir.setContent({ + 'index.html.tmpl': '', + }); + await injectConfigIntoHtml({ + ...baseOptions, + appConfigs: [ + { + context: 'mock', + data: { x: "" }, + }, + ], + }); + expect(mockDir.content()).toMatchObject({ + 'index.html': ` + `, }); }); diff --git a/plugins/app-backend/src/lib/config/injectConfigIntoHtml.ts b/plugins/app-backend/src/lib/config/injectConfigIntoHtml.ts index 604b6a8711..c0c1ca200a 100644 --- a/plugins/app-backend/src/lib/config/injectConfigIntoHtml.ts +++ b/plugins/app-backend/src/lib/config/injectConfigIntoHtml.ts @@ -55,7 +55,14 @@ export async function injectConfigIntoHtml( '', ` `, );