From 8c83ce8084df178556d60752bf3f0f0c50db4473 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Sat, 13 Nov 2021 10:38:49 +0100
Subject: [PATCH] cli: leave initial create logging to the factories

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 packages/cli/src/commands/create/create.ts                   | 3 ---
 packages/cli/src/lib/create/factories/backendPlugin.test.ts  | 2 ++
 packages/cli/src/lib/create/factories/backendPlugin.ts       | 4 ++++
 packages/cli/src/lib/create/factories/frontendPlugin.test.ts | 2 ++
 packages/cli/src/lib/create/factories/frontendPlugin.ts      | 4 ++++
 packages/cli/src/lib/create/factories/pluginCommon.test.ts   | 2 ++
 packages/cli/src/lib/create/factories/pluginCommon.ts        | 4 ++++
 7 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/packages/cli/src/commands/create/create.ts b/packages/cli/src/commands/create/create.ts
index 5fff07b194..d80daa6ddf 100644
--- a/packages/cli/src/commands/create/create.ts
+++ b/packages/cli/src/commands/create/create.ts
@@ -80,9 +80,6 @@ export default async (cmd: Command) => {
 
   let modified = false;
   try {
-    Task.log();
-    Task.log(`Creating new ${factory.name}`);
-
     await factory.create(options, {
       isMonoRepo,
       defaultVersion,
diff --git a/packages/cli/src/lib/create/factories/backendPlugin.test.ts b/packages/cli/src/lib/create/factories/backendPlugin.test.ts
index 1100b3001e..cf597572ad 100644
--- a/packages/cli/src/lib/create/factories/backendPlugin.test.ts
+++ b/packages/cli/src/lib/create/factories/backendPlugin.test.ts
@@ -90,6 +90,8 @@ describe('backendPlugin factory', () => {
     expect(modified).toBe(true);
 
     expect(output).toEqual([
+      '',
+      'Creating backend plugin plugin-test-backend',
       'Checking Prerequisites:',
       'availability  plugins/test-backend ✔',
       'creating      temp dir ✔',
diff --git a/packages/cli/src/lib/create/factories/backendPlugin.ts b/packages/cli/src/lib/create/factories/backendPlugin.ts
index 2fd461c2a9..2bdc62741d 100644
--- a/packages/cli/src/lib/create/factories/backendPlugin.ts
+++ b/packages/cli/src/lib/create/factories/backendPlugin.ts
@@ -15,6 +15,7 @@
  */
 
 import fs from 'fs-extra';
+import chalk from 'chalk';
 import camelCase from 'lodash/camelCase';
 import { paths } from '../../paths';
 import { addCodeownersEntry, getCodeownersFilePath } from '../../codeowners';
@@ -40,6 +41,9 @@ export const backendPlugin = createFactory<Options>({
     const id = `${options.id}-backend`;
     const name = ctx.scope ? `@${ctx.scope}/plugin-${id}` : `plugin-${id}`;
 
+    Task.log();
+    Task.log(`Creating backend plugin ${chalk.cyan(name)}`);
+
     const targetDir = ctx.isMonoRepo
       ? paths.resolveTargetRoot('plugins', id)
       : paths.resolveTargetRoot(`backstage-plugin-${id}`);
diff --git a/packages/cli/src/lib/create/factories/frontendPlugin.test.ts b/packages/cli/src/lib/create/factories/frontendPlugin.test.ts
index fe815ce80f..3b24f95e41 100644
--- a/packages/cli/src/lib/create/factories/frontendPlugin.test.ts
+++ b/packages/cli/src/lib/create/factories/frontendPlugin.test.ts
@@ -103,6 +103,8 @@ describe('frontendPlugin factory', () => {
     expect(modified).toBe(true);
 
     expect(output).toEqual([
+      '',
+      'Creating backend plugin plugin-test',
       'Checking Prerequisites:',
       'availability  plugins/test ✔',
       'creating      temp dir ✔',
diff --git a/packages/cli/src/lib/create/factories/frontendPlugin.ts b/packages/cli/src/lib/create/factories/frontendPlugin.ts
index 50e8dd42a3..a6c0d0470d 100644
--- a/packages/cli/src/lib/create/factories/frontendPlugin.ts
+++ b/packages/cli/src/lib/create/factories/frontendPlugin.ts
@@ -15,6 +15,7 @@
  */
 
 import fs from 'fs-extra';
+import chalk from 'chalk';
 import camelCase from 'lodash/camelCase';
 import upperFirst from 'lodash/upperFirst';
 import { paths } from '../../paths';
@@ -43,6 +44,9 @@ export const frontendPlugin = createFactory<Options>({
     const name = ctx.scope ? `@${ctx.scope}/plugin-${id}` : `plugin-${id}`;
     const extensionName = `${upperFirst(camelCase(id))}Page`;
 
+    Task.log();
+    Task.log(`Creating backend plugin ${chalk.cyan(name)}`);
+
     const targetDir = ctx.isMonoRepo
       ? paths.resolveTargetRoot('plugins', id)
       : paths.resolveTargetRoot(`backstage-plugin-${id}`);
diff --git a/packages/cli/src/lib/create/factories/pluginCommon.test.ts b/packages/cli/src/lib/create/factories/pluginCommon.test.ts
index f7251dc443..6e797f4cca 100644
--- a/packages/cli/src/lib/create/factories/pluginCommon.test.ts
+++ b/packages/cli/src/lib/create/factories/pluginCommon.test.ts
@@ -85,6 +85,8 @@ describe('pluginCommon factory', () => {
     expect(modified).toBe(true);
 
     expect(output).toEqual([
+      '',
+      'Creating backend plugin plugin-test-common',
       'Checking Prerequisites:',
       'availability  plugins/test-common ✔',
       'creating      temp dir ✔',
diff --git a/packages/cli/src/lib/create/factories/pluginCommon.ts b/packages/cli/src/lib/create/factories/pluginCommon.ts
index 5a6dd30046..97b1eccec7 100644
--- a/packages/cli/src/lib/create/factories/pluginCommon.ts
+++ b/packages/cli/src/lib/create/factories/pluginCommon.ts
@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import chalk from 'chalk';
 import { paths } from '../../paths';
 import { addCodeownersEntry, getCodeownersFilePath } from '../../codeowners';
 import { createFactory, CreateContext } from '../types';
@@ -38,6 +39,9 @@ export const pluginCommon = createFactory<Options>({
     const id = `${options.id}-common`;
     const name = ctx.scope ? `@${ctx.scope}/plugin-${id}` : `plugin-${id}`;
 
+    Task.log();
+    Task.log(`Creating backend plugin ${chalk.cyan(name)}`);
+
     const targetDir = ctx.isMonoRepo
       ? paths.resolveTargetRoot('plugins', id)
       : paths.resolveTargetRoot(`backstage-plugin-${id}`);