From 8c7d59c923b29a0fdb468810b95bfcc840d19bc5 Mon Sep 17 00:00:00 2001
From: headphonejames <generalfuzz@gmail.com>
Date: Mon, 10 Apr 2023 09:22:09 -0700
Subject: [PATCH] remove the selectedOptions check from the useEffect hook to
 allow updates to options when options are included in the query string.

Signed-off-by: headphonejames <generalfuzz@gmail.com>
---
 .../EntityAutocompletePicker.tsx                      | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/plugins/catalog-react/src/components/EntityAutocompletePicker/EntityAutocompletePicker.tsx b/plugins/catalog-react/src/components/EntityAutocompletePicker/EntityAutocompletePicker.tsx
index 00114a29fc..20294fa7f1 100644
--- a/plugins/catalog-react/src/components/EntityAutocompletePicker/EntityAutocompletePicker.tsx
+++ b/plugins/catalog-react/src/components/EntityAutocompletePicker/EntityAutocompletePicker.tsx
@@ -95,12 +95,11 @@ export function EntityAutocompletePicker<
 
   // Set selected options on query parameter updates; this happens at initial page load and from
   // external updates to the page location
-  const [prevQueryParameters, setQueryParameter] = useState(queryParameters);
-  // if the query parameter has changed, update the selected options
-  if (queryParameters !== prevQueryParameters) {
-    setSelectedOptions(queryParameters);
-    setQueryParameter(queryParameters);
-  }
+  useEffect(() => {
+    if (queryParameters.length) {
+      setSelectedOptions(queryParameters);
+    }
+  }, [queryParameters]);
 
   const availableOptions = Object.keys(availableValues ?? {});
   const shouldAddFilter = selectedOptions.length && availableOptions.length;