diff --git a/.changeset/loud-vans-pretend.md b/.changeset/loud-vans-pretend.md new file mode 100644 index 0000000000..1e2498284b --- /dev/null +++ b/.changeset/loud-vans-pretend.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-search': patch +--- + +Fix Material-UI warning for search filtering diff --git a/plugins/search/src/components/Filters/Filters.tsx b/plugins/search/src/components/Filters/Filters.tsx index 7bd344e12e..888a583547 100644 --- a/plugins/search/src/components/Filters/Filters.tsx +++ b/plugins/search/src/components/Filters/Filters.tsx @@ -103,7 +103,7 @@ export const Filters = ({ > {filterOptions.kind.map(filter => ( { const [showFilters, toggleFilters] = useState(false); const [selectedFilters, setSelectedFilters] = useState({ - selected: 'All', + selected: '', checked: [], }); @@ -146,7 +146,7 @@ export const SearchResult = ({ searchQuery }: SearchResultProps) => { // apply filters // filter on selected - if (selectedFilters.selected !== 'All') { + if (selectedFilters.selected !== '') { withFilters = results.filter((result: Result) => selectedFilters.selected.includes(result.kind), ); @@ -192,7 +192,7 @@ export const SearchResult = ({ searchQuery }: SearchResultProps) => { const resetFilters = () => { setSelectedFilters({ - selected: 'All', + selected: '', checked: [], }); }; @@ -259,7 +259,7 @@ export const SearchResult = ({ searchQuery }: SearchResultProps) => { searchQuery={searchQuery} numberOfResults={filteredResults.length} numberOfSelectedFilters={ - (selectedFilters.selected !== 'All' ? 1 : 0) + + (selectedFilters.selected !== '' ? 1 : 0) + selectedFilters.checked.length } handleToggleFilters={() => toggleFilters(!showFilters)}