From 8c3f30cb28196312f4e2bd79f690e7243e392c13 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Wed, 2 Mar 2022 12:29:24 +0100
Subject: [PATCH] cli: remove deprecated index.html templating variables

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .changeset/orange-crews-explain.md     |  5 ++++
 packages/cli/src/lib/bundler/config.ts | 33 --------------------------
 2 files changed, 5 insertions(+), 33 deletions(-)
 create mode 100644 .changeset/orange-crews-explain.md

diff --git a/.changeset/orange-crews-explain.md b/.changeset/orange-crews-explain.md
new file mode 100644
index 0000000000..4b831392eb
--- /dev/null
+++ b/.changeset/orange-crews-explain.md
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': minor
+---
+
+**BREAKING**: Removed the deprecated `app.<key>` template variables from the `index.html` templating. These should be replaced by using `config.getString("app.<key>")` instead.
diff --git a/packages/cli/src/lib/bundler/config.ts b/packages/cli/src/lib/bundler/config.ts
index fe64f23209..bfd05807ad 100644
--- a/packages/cli/src/lib/bundler/config.ts
+++ b/packages/cli/src/lib/bundler/config.ts
@@ -15,7 +15,6 @@
  */
 
 import fs from 'fs-extra';
-import chalk from 'chalk';
 import { resolve as resolvePath } from 'path';
 import ForkTsCheckerWebpackPlugin from 'fork-ts-checker-webpack-plugin';
 import HtmlWebpackPlugin from 'html-webpack-plugin';
@@ -118,43 +117,11 @@ export async function createConfig(
     }),
   );
 
-  const appParamDeprecationMsg = chalk.red(
-    'DEPRECATION WARNING: using `app.<key>` in the index.html template is deprecated, use `config.getString("app.<key>")` instead.',
-  );
   plugins.push(
     new HtmlWebpackPlugin({
       template: paths.targetHtml,
       templateParameters: {
         publicPath: validBaseUrl.pathname.replace(/\/$/, ''),
-        app: {
-          get title() {
-            console.warn(appParamDeprecationMsg);
-            return frontendConfig.getString('app.title');
-          },
-          get baseUrl() {
-            console.warn(appParamDeprecationMsg);
-            return validBaseUrl.href;
-          },
-          get googleAnalyticsTrackingId() {
-            console.warn(appParamDeprecationMsg);
-            return frontendConfig.getOptionalString(
-              'app.googleAnalyticsTrackingId',
-            );
-          },
-          get datadogRum() {
-            console.warn(appParamDeprecationMsg);
-            return {
-              env: frontendConfig.getOptionalString('app.datadogRum.env'),
-              clientToken: frontendConfig.getOptionalString(
-                'app.datadogRum.clientToken',
-              ),
-              applicationId: frontendConfig.getOptionalString(
-                'app.datadogRum.applicationId',
-              ),
-              site: frontendConfig.getOptionalString('app.datadogRum.site'),
-            };
-          },
-        },
         config: frontendConfig,
       },
     }),