From 8bbf95b55072e6a9a43d49c384cf7fee3f352ce5 Mon Sep 17 00:00:00 2001 From: Avantika Iyer Date: Mon, 6 Mar 2023 16:20:02 +0000 Subject: [PATCH] Replace style override fix with a Classes prop override instead (#16621) * replace style override fix Signed-off-by: Avantika Iyer * Update clean-lemons-jump.md Signed-off-by: Avantika Iyer * Update clean-lemons-jump.md Signed-off-by: Avantika Iyer * Update .changeset/clean-lemons-jump.md Signed-off-by: Patrik Oldsberg --------- Signed-off-by: Avantika Iyer Signed-off-by: Patrik Oldsberg Co-authored-by: Patrik Oldsberg --- .changeset/clean-lemons-jump.md | 7 +++++++ packages/core-components/src/layout/Sidebar/Bar.tsx | 3 --- packages/core-components/src/layout/Sidebar/Items.tsx | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/clean-lemons-jump.md diff --git a/.changeset/clean-lemons-jump.md b/.changeset/clean-lemons-jump.md new file mode 100644 index 0000000000..ab6f22136a --- /dev/null +++ b/.changeset/clean-lemons-jump.md @@ -0,0 +1,7 @@ +--- +'@backstage/core-components': patch +--- + +Button labels in the sidebar (previously displayed in uppercase) will be displayed in the case that is provided without any transformations. +For example, a sidebar button with the label "Search" will appear as Search, "search" will appear as search, "SEARCH" will appear as SEARCH etc. +This can potentially affect any overriding styles previously applied to change the appearance of Button labels in the Sidebar. diff --git a/packages/core-components/src/layout/Sidebar/Bar.tsx b/packages/core-components/src/layout/Sidebar/Bar.tsx index 95ed88b1ec..69b77dd5e1 100644 --- a/packages/core-components/src/layout/Sidebar/Bar.tsx +++ b/packages/core-components/src/layout/Sidebar/Bar.tsx @@ -63,9 +63,6 @@ const useStyles = makeStyles( '&::-webkit-scrollbar': { display: 'none', }, - '& .MuiButtonBase-root': { - textTransform: 'none', - }, }), drawerOpen: props => ({ width: props.sidebarConfig.drawerWidthOpen, diff --git a/packages/core-components/src/layout/Sidebar/Items.tsx b/packages/core-components/src/layout/Sidebar/Items.tsx index 823320403e..00d1871947 100644 --- a/packages/core-components/src/layout/Sidebar/Items.tsx +++ b/packages/core-components/src/layout/Sidebar/Items.tsx @@ -103,6 +103,7 @@ const makeSidebarStyles = (sidebarConfig: SidebarConfig) => padding: 0, textAlign: 'inherit', font: 'inherit', + textTransform: 'none', }, closed: { width: sidebarConfig.drawerWidthClosed,