From 8abfa78e4cfdf49f9bb7fa9dc5a8387fa1d55383 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Tue, 19 May 2026 23:23:37 +0200 Subject: [PATCH] =?UTF-8?q?Revert=20eachSupportedId=20guard=20=E2=80=94=20?= =?UTF-8?q?env=20var=20fix=20is=20sufficient?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Opus 4.6 (1M context) Signed-off-by: Fredrik Adelöw --- .changeset/fix-empty-each-tests.md | 5 ----- packages/backend-test-utils/src/cache/TestCaches.ts | 3 --- packages/backend-test-utils/src/database/TestDatabases.ts | 7 ------- 3 files changed, 15 deletions(-) delete mode 100644 .changeset/fix-empty-each-tests.md diff --git a/.changeset/fix-empty-each-tests.md b/.changeset/fix-empty-each-tests.md deleted file mode 100644 index 71cc06c30d..0000000000 --- a/.changeset/fix-empty-each-tests.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@backstage/backend-test-utils': patch ---- - -Fixed a crash in test suites that use `TestDatabases` or `TestCaches` when none of the requested database or cache engines are available. Previously, `eachSupportedId()` would return an empty array causing `describe.each` to throw and prevent the entire suite from running. Now returns a placeholder entry so individual tests report a clear failure instead. diff --git a/packages/backend-test-utils/src/cache/TestCaches.ts b/packages/backend-test-utils/src/cache/TestCaches.ts index 27c07daa32..d4553697bf 100644 --- a/packages/backend-test-utils/src/cache/TestCaches.ts +++ b/packages/backend-test-utils/src/cache/TestCaches.ts @@ -108,9 +108,6 @@ export class TestCaches { } eachSupportedId(): [TestCacheId][] { - if (this.supportedIds.length === 0) { - return [['MISSING' as TestCacheId]]; - } return this.supportedIds.map(id => [id]); } diff --git a/packages/backend-test-utils/src/database/TestDatabases.ts b/packages/backend-test-utils/src/database/TestDatabases.ts index 46d966b6ee..8baac04193 100644 --- a/packages/backend-test-utils/src/database/TestDatabases.ts +++ b/packages/backend-test-utils/src/database/TestDatabases.ts @@ -124,13 +124,6 @@ export class TestDatabases { } eachSupportedId(): [TestDatabaseId][] { - if (this.supportedIds.length === 0) { - // Return a placeholder so that describe.each/it.each does not throw - // when no databases are available. The init() call will throw for - // the unknown ID, causing the test to be reported as failed rather - // than crashing the entire suite. - return [['MISSING' as TestDatabaseId]]; - } return this.supportedIds.map(id => [id]); }