From 05b916761d036f1366abf084f1fb7f4d1782b491 Mon Sep 17 00:00:00 2001
From: Himanshu Mishra <himanshu@orkohunter.net>
Date: Mon, 23 Nov 2020 21:05:37 +0100
Subject: [PATCH 1/3] fix(kubernetes-backend): Fix Typescript error stopping
 backend to start

---
 .../src/service/getKubernetesObjectsForServiceHandler.ts      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/kubernetes-backend/src/service/getKubernetesObjectsForServiceHandler.ts b/plugins/kubernetes-backend/src/service/getKubernetesObjectsForServiceHandler.ts
index 1b0cf4f783..82220f5d6c 100644
--- a/plugins/kubernetes-backend/src/service/getKubernetesObjectsForServiceHandler.ts
+++ b/plugins/kubernetes-backend/src/service/getKubernetesObjectsForServiceHandler.ts
@@ -97,12 +97,12 @@ export const handleGetKubernetesObjectsForService: GetKubernetesObjectsForServic
   return Promise.all(
     clusterDetailsDecoratedForAuth.map(clusterDetails => {
       return fetcher
-        .fetchObjectsForService(<ObjectFetchParams>{
+        .fetchObjectsForService({
           serviceId,
           clusterDetails,
           objectTypesToFetch,
           labelSelector,
-        })
+        } as ObjectFetchParams)
         .then(result => {
           return {
             cluster: {

From ef5810f51358fb8752f1917af5480746f0c4bbbc Mon Sep 17 00:00:00 2001
From: Himanshu Mishra <himanshu@orkohunter.net>
Date: Mon, 23 Nov 2020 21:40:12 +0100
Subject: [PATCH 2/3] eslint: Enforce consistent TS type assertions

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/consistent-type-assertions.md
---
 packages/cli/config/eslint.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/cli/config/eslint.js b/packages/cli/config/eslint.js
index 9b1880c1db..e2a807e42e 100644
--- a/packages/cli/config/eslint.js
+++ b/packages/cli/config/eslint.js
@@ -58,6 +58,7 @@ module.exports = {
     ],
     'no-unused-expressions': 'off',
     '@typescript-eslint/no-unused-expressions': 'error',
+    '@typescript-eslint/consistent-type-assertions': 'error',
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {

From faf311c261be51c547469432c6551fa926741d08 Mon Sep 17 00:00:00 2001
From: Himanshu Mishra <himanshu@orkohunter.net>
Date: Mon, 23 Nov 2020 21:57:34 +0100
Subject: [PATCH 3/3] backstage-cli: Add changeset about new lint rule

---
 .changeset/new-ladybugs-nail.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/new-ladybugs-nail.md

diff --git a/.changeset/new-ladybugs-nail.md b/.changeset/new-ladybugs-nail.md
new file mode 100644
index 0000000000..5351b6dff3
--- /dev/null
+++ b/.changeset/new-ladybugs-nail.md
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+New lint rule to disallow <type> assertions and promote `as` assertions. - @typescript-eslint/consistent-type-assertions