From 8ab3218c1a68a8d0e2011e59f1d50a3c57f6a162 Mon Sep 17 00:00:00 2001
From: Karthikeyan Perumal <7823084+karthikeyanjp@users.noreply.github.com>
Date: Fri, 1 Mar 2024 20:28:37 -0600
Subject: [PATCH] Fixed bug in WorkflowRunStatus component where skipped &
cancelled status were shown as completed
Signed-off-by: Karthikeyan Perumal <7823084+karthikeyanjp@users.noreply.github.com>
---
.changeset/good-seals-argue.md | 5 +++++
.../src/components/WorkflowRunStatus/WorkflowRunStatus.tsx | 3 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
create mode 100644 .changeset/good-seals-argue.md
diff --git a/.changeset/good-seals-argue.md b/.changeset/good-seals-argue.md
new file mode 100644
index 0000000000..c50d275a87
--- /dev/null
+++ b/.changeset/good-seals-argue.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-github-actions': patch
+---
+
+Fixed bug in WorkflowRunStatus component where skipped and cancelled workflow runs appeared as success
diff --git a/plugins/github-actions/src/components/WorkflowRunStatus/WorkflowRunStatus.tsx b/plugins/github-actions/src/components/WorkflowRunStatus/WorkflowRunStatus.tsx
index f5d1c223ba..48d736aa76 100644
--- a/plugins/github-actions/src/components/WorkflowRunStatus/WorkflowRunStatus.tsx
+++ b/plugins/github-actions/src/components/WorkflowRunStatus/WorkflowRunStatus.tsx
@@ -52,7 +52,8 @@ export function WorkflowIcon({
return ;
case 'completed':
switch (conclusion?.toLocaleLowerCase('en-US')) {
- case 'skipped' || 'canceled':
+ case 'skipped':
+ case 'cancelled':
return ;
case 'timed_out':