From 89da341a141d657d641df693e1721e23edfa4dc1 Mon Sep 17 00:00:00 2001 From: MT Lewis Date: Mon, 1 Sep 2025 15:28:07 +0100 Subject: [PATCH] fix(ui): attach aria-label and aria-labelledby props to Select component MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Select component was accepting aria-label and aria-labelledby props but not forwarding them to the underlying AriaSelect element, making them ineffective for accessibility. This fix ensures these props are properly attached to the rendered element. 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: MT Lewis Co-Authored-By: Claude --- .changeset/fix-select-aria-props.md | 5 +++++ packages/ui/src/components/Select/Select.tsx | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 .changeset/fix-select-aria-props.md diff --git a/.changeset/fix-select-aria-props.md b/.changeset/fix-select-aria-props.md new file mode 100644 index 0000000000..66bb1de3ad --- /dev/null +++ b/.changeset/fix-select-aria-props.md @@ -0,0 +1,5 @@ +--- +'@backstage/ui': patch +--- + +Fix Select component to properly attach aria-label and aria-labelledby props to the rendered element for improved accessibility. diff --git a/packages/ui/src/components/Select/Select.tsx b/packages/ui/src/components/Select/Select.tsx index c63e8964ab..f38311b117 100644 --- a/packages/ui/src/components/Select/Select.tsx +++ b/packages/ui/src/components/Select/Select.tsx @@ -70,6 +70,8 @@ export const Select = forwardRef((props, ref) => { className={clsx(classNames.root, className)} {...dataAttributes} ref={ref} + aria-label={ariaLabel} + aria-labelledby={ariaLabelledBy} {...rest} >