From 88c9eac54dcc0447e969ed1d412d7088aee923b6 Mon Sep 17 00:00:00 2001 From: Erik Engervall Date: Tue, 20 Apr 2021 22:04:02 +0200 Subject: [PATCH] PromoteRc component rename Signed-off-by: Erik Engervall --- .../src/cards/Cards.test.tsx | 53 +++++++++++++++++-- .../src/cards/Cards.tsx | 4 +- .../PromoteRc.test.tsx | 10 ++-- .../PromoteRc.tsx | 7 +-- .../PromoteRcBody.test.tsx | 0 .../PromoteRcBody.tsx | 0 .../hooks/usePromoteRc.test.ts | 0 .../hooks/usePromoteRc.ts | 0 8 files changed, 58 insertions(+), 16 deletions(-) rename plugins/github-release-manager/src/cards/{PromoteReleaseCandidate => PromoteRc}/PromoteRc.test.tsx (83%) rename plugins/github-release-manager/src/cards/{PromoteReleaseCandidate => PromoteRc}/PromoteRc.tsx (93%) rename plugins/github-release-manager/src/cards/{PromoteReleaseCandidate => PromoteRc}/PromoteRcBody.test.tsx (100%) rename plugins/github-release-manager/src/cards/{PromoteReleaseCandidate => PromoteRc}/PromoteRcBody.tsx (100%) rename plugins/github-release-manager/src/cards/{PromoteReleaseCandidate => PromoteRc}/hooks/usePromoteRc.test.ts (100%) rename plugins/github-release-manager/src/cards/{PromoteReleaseCandidate => PromoteRc}/hooks/usePromoteRc.ts (100%) diff --git a/plugins/github-release-manager/src/cards/Cards.test.tsx b/plugins/github-release-manager/src/cards/Cards.test.tsx index 2a67a9f62c..dfb5491842 100644 --- a/plugins/github-release-manager/src/cards/Cards.test.tsx +++ b/plugins/github-release-manager/src/cards/Cards.test.tsx @@ -46,8 +46,55 @@ describe('Cards', () => { await waitFor(() => getByTestId(TEST_IDS.info.info)); }); - expect(getByTestId(TEST_IDS.info.info).innerHTML).toMatchInlineSnapshot( - `"
Terminology

GitHub: The source control system where releases reside in a practical sense. Read more about GitHub releases. (Note that this plugin works just as well with GitHub Enterprise.)

Release Candidate: A GitHub prerelease intended primarily for internal testing

Release Version: A GitHub release intended for end users

"`, - ); + expect(getByTestId(TEST_IDS.info.info)).toMatchInlineSnapshot(` +
+
+ Terminology +
+

+ + GitHub + + : The source control system where releases reside in a practical sense. Read more about + + + GitHub releases + + . (Note that this plugin works just as well with GitHub Enterprise.) +

+

+ + Release Candidate + + : A GitHub + + prerelease + + + intended primarily for internal testing +

+

+ + Release Version + + : A GitHub release intended for end users +

+
+ `); }); }); diff --git a/plugins/github-release-manager/src/cards/Cards.tsx b/plugins/github-release-manager/src/cards/Cards.tsx index 5fbb7fb1f7..3463ffa2e3 100644 --- a/plugins/github-release-manager/src/cards/Cards.tsx +++ b/plugins/github-release-manager/src/cards/Cards.tsx @@ -23,7 +23,7 @@ import { CreateRc } from './CreateRc/CreateRc'; import { GitHubReleaseManagerProps } from '../GitHubReleaseManager'; import { Info } from './Info/Info'; import { Patch } from './Patch/Patch'; -import { PromoteReleaseCandidate } from './PromoteReleaseCandidate/PromoteRc'; +import { PromoteRc } from './PromoteRc/PromoteRc'; import { RefetchContext } from '../contexts/RefetchContext'; import { useGetGitHubBatchInfo } from '../hooks/useGetGitHubBatchInfo'; import { usePluginApiClientContext } from '../contexts/PluginApiClientContext'; @@ -111,7 +111,7 @@ export function Cards({ )} {!components?.promoteRc?.omit && ( - diff --git a/plugins/github-release-manager/src/cards/PromoteReleaseCandidate/PromoteRc.test.tsx b/plugins/github-release-manager/src/cards/PromoteRc/PromoteRc.test.tsx similarity index 83% rename from plugins/github-release-manager/src/cards/PromoteReleaseCandidate/PromoteRc.test.tsx rename to plugins/github-release-manager/src/cards/PromoteRc/PromoteRc.test.tsx index e917c295d6..f4e7c1fb41 100644 --- a/plugins/github-release-manager/src/cards/PromoteReleaseCandidate/PromoteRc.test.tsx +++ b/plugins/github-release-manager/src/cards/PromoteRc/PromoteRc.test.tsx @@ -29,13 +29,11 @@ jest.mock('./PromoteRcBody', () => ({ ), })); -import { PromoteReleaseCandidate } from './PromoteRc'; +import { PromoteRc } from './PromoteRc'; describe('PromoteRc', () => { it('return early if no latest release present', () => { - const { getByTestId } = render( - , - ); + const { getByTestId } = render(); expect( getByTestId(TEST_IDS.components.noLatestRelease), @@ -44,7 +42,7 @@ describe('PromoteRc', () => { it('should display not-rc warning', () => { const { getByTestId } = render( - , + , ); expect(getByTestId(TEST_IDS.promoteRc.notRcWarning)).toBeInTheDocument(); @@ -52,7 +50,7 @@ describe('PromoteRc', () => { it('should display PromoteRcBody', () => { const { getByTestId } = render( - , + , ); expect( diff --git a/plugins/github-release-manager/src/cards/PromoteReleaseCandidate/PromoteRc.tsx b/plugins/github-release-manager/src/cards/PromoteRc/PromoteRc.tsx similarity index 93% rename from plugins/github-release-manager/src/cards/PromoteReleaseCandidate/PromoteRc.tsx rename to plugins/github-release-manager/src/cards/PromoteRc/PromoteRc.tsx index 56b506bcab..5d2783bcfd 100644 --- a/plugins/github-release-manager/src/cards/PromoteReleaseCandidate/PromoteRc.tsx +++ b/plugins/github-release-manager/src/cards/PromoteRc/PromoteRc.tsx @@ -26,15 +26,12 @@ import { PromoteRcBody } from './PromoteRcBody'; import { TEST_IDS } from '../../test-helpers/test-ids'; import { useStyles } from '../../styles/styles'; -interface PromoteReleaseCandidateProps { +interface PromoteRcProps { latestRelease: GetLatestReleaseResult; successCb?: ComponentConfigPromoteRc['successCb']; } -export const PromoteReleaseCandidate = ({ - latestRelease, - successCb, -}: PromoteReleaseCandidateProps) => { +export const PromoteRc = ({ latestRelease, successCb }: PromoteRcProps) => { const classes = useStyles(); function Body() { diff --git a/plugins/github-release-manager/src/cards/PromoteReleaseCandidate/PromoteRcBody.test.tsx b/plugins/github-release-manager/src/cards/PromoteRc/PromoteRcBody.test.tsx similarity index 100% rename from plugins/github-release-manager/src/cards/PromoteReleaseCandidate/PromoteRcBody.test.tsx rename to plugins/github-release-manager/src/cards/PromoteRc/PromoteRcBody.test.tsx diff --git a/plugins/github-release-manager/src/cards/PromoteReleaseCandidate/PromoteRcBody.tsx b/plugins/github-release-manager/src/cards/PromoteRc/PromoteRcBody.tsx similarity index 100% rename from plugins/github-release-manager/src/cards/PromoteReleaseCandidate/PromoteRcBody.tsx rename to plugins/github-release-manager/src/cards/PromoteRc/PromoteRcBody.tsx diff --git a/plugins/github-release-manager/src/cards/PromoteReleaseCandidate/hooks/usePromoteRc.test.ts b/plugins/github-release-manager/src/cards/PromoteRc/hooks/usePromoteRc.test.ts similarity index 100% rename from plugins/github-release-manager/src/cards/PromoteReleaseCandidate/hooks/usePromoteRc.test.ts rename to plugins/github-release-manager/src/cards/PromoteRc/hooks/usePromoteRc.test.ts diff --git a/plugins/github-release-manager/src/cards/PromoteReleaseCandidate/hooks/usePromoteRc.ts b/plugins/github-release-manager/src/cards/PromoteRc/hooks/usePromoteRc.ts similarity index 100% rename from plugins/github-release-manager/src/cards/PromoteReleaseCandidate/hooks/usePromoteRc.ts rename to plugins/github-release-manager/src/cards/PromoteRc/hooks/usePromoteRc.ts