Fail when adding duplicate locations using the dry run flag

This change here adds in logic to the DefaultLocationService that will prematurely terminate the dry run addition of locations if there is a duplicate entity in the unprocessed entities.
Adding this logic here will avoid an infinite loop if a monorepo arch is used (for example if a target references itself). It will also enforce some best practices.
I have also added tests.

You can test this out using this catalog-info.yaml: https://github.com/RoadieHQ/monorepo-infinte-loop/blob/main/catalog-info.yaml

Signed-off-by: Nicolas Arnold <nic@roadie.io>

This commit is contained in:

Nicolas Arnold

2021-11-18 17:42:17 +00:00

parent fb03c47c8b

commit 8866b62f3d

3 changed files with 88 additions and 18 deletions

.changeset/thirty-fireants-occur.md

View File

@@ -0,0 +1,5 @@
 ---
 '@backstage/plugin-catalog-backend': patch
 ---
 Detect a duplicate entities when adding locations through dry run